Fix multiple requests for the same traceId in Tornado#209
Fix multiple requests for the same traceId in Tornado#209YueLangsugar wants to merge 3 commits intoapache:masterfrom YueLangsugar:master
Conversation
…val of span in tornado request link
|
Please update your pull request title and text body, it's not readable. |
|
Please also update the |
ok, It's modified |
I've updated it. |
kezhenxu94
left a comment
There was a problem hiding this comment.
This patch doesn't make sense, it fixes (maybe) issues in tornado but breaks many other things, @YueLangsugar did you read the reply from @Superskyyy in apache/skywalking#9133?
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
I've read it, but I don't think it helps. |
Please, let's discuss and have a consensus first in apache/skywalking#9133 , I don't think you can modify something but "you don't know why". You face issues in Tornado plugin but you are modifying the agent core, this doesn't make sense to me, and it may bring side effects that you are unaware of. |
Uh oh!
There was an error while loading. Please reload this page.