Skip to content

Fix multiple requests for the same traceId in Tornado #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YueLangsugar wants to merge 3 commits into from
Closed

Fix multiple requests for the same traceId in Tornado #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfd22eb
The context of obtaining span is modified, which will affect the remo…
May 26, 2022
d3ca2f4
update CHANGELOG.md
May 27, 2022
d9c1379
Update CHANGELOG.md
YueLangsugar May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Drop support for flask 1.x due to dependency issue in Jinja2 and EOL (#195)

- Fixes:
- Fix the problem of multiple requests for the same traceId in Tornado framework (#209)
- Spans now correctly reference finished parents (#161)
- Remove potential password leak from Aiohttp outgoing url (#175)
- Handle error when REMOTE_PORT is missing in Flask (#176)
Expand Down
5 changes: 1 addition & 4 deletions skywalking/trace/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ def _spans(): # need to do this because can't set mutable default = [] in conte
return spans

def _spans_dup():
spans = __spans.get()[:]
__spans.set(spans)

return spans
return __spans.get()

__spans.set([])

Expand Down