[Core][BugFix] Add content equality of SegmentRef#30
Merged
kezhenxu94 merged 1 commit intomasterfrom Jul 2, 2020
Merged
Conversation
kezhenxu94
force-pushed
the
bugfix/equality-of-segment-ref
branch
from
7083b85 to
50c4772
Compare
wu-sheng
approved these changes
Jul 2, 2020
Member
|
Is python facing duplicated trace id? |
Member
Author
No, this fixes the duplicate refs when one framework is built on another, for example, Flask is built on top of requests skywalking-python/skywalking/trace/span/__init__.py Lines 173 to 174 in d121c14 |
Member
|
Oh, I see. So, python agent only had ref override self trace id mechanism, no ref override and ignorance mechanisms, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.