Skip to content

[Core][BugFix] Add content equality of SegmentRef #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kezhenxu94 merged 1 commit into from
Jul 2, 2020
Merged

[Core][BugFix] Add content equality of SegmentRef #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions skywalking/trace/segment/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,18 @@ def __init__(self, carrier: 'Carrier'):
self.endpoint = carrier.endpoint # type: str
self.client_address = carrier.client_address # type: str

def __eq__(self, other):
if not isinstance(other, SegmentRef):
raise NotImplementedError
return self.ref_type == other.ref_type and \
self.trace_id == other.trace_id and \
self.segment_id == other.segment_id and \
self.span_id == other.span_id and \
self.service == other.service and \
self.service_instance == other.service_instance and \
self.endpoint == other.endpoint and \
self.client_address == other.client_address


class _NewID(ID):
pass
Expand Down