Skip to content
This repository was archived by the owner on Jun 1, 2022. It is now read-only.

Add PyMsql icon#331

Merged
wu-sheng merged 6 commits intoapache:masterfrom
alonelaval:master
Jul 18, 2020
Merged

Add PyMsql icon#331
wu-sheng merged 6 commits intoapache:masterfrom
alonelaval:master

Conversation

@alonelaval
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng added this to the 8.1.0 milestone Jul 18, 2020
@wu-sheng wu-sheng added the enhancement New feature or request label Jul 18, 2020
@wu-sheng wu-sheng merged commit 7d95c76 into apache:master Jul 18, 2020
@wu-sheng
Copy link
Copy Markdown
Member

The submodule of the main repo is required to be updated

@wu-sheng
Copy link
Copy Markdown
Member

@kezhenxu94 By looking at apache/skywalking#5121, I feel this PR is not right. MySQL already has one icon, we don't need the PyMsql, anything I missed? If not, this PR should be reverted.

wu-sheng added a commit that referenced this pull request Jul 18, 2020
kezhenxu94 pushed a commit that referenced this pull request Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants