Skip to content

Add PyMysql component#5121

Merged
wu-sheng merged 8 commits intoapache:masterfrom
alonelaval:master
Jul 19, 2020
Merged

Add PyMysql component#5121
wu-sheng merged 8 commits intoapache:masterfrom
alonelaval:master

Conversation

@alonelaval
Copy link
Copy Markdown
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2020

Codecov Report

Merging #5121 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5121      +/-   ##
============================================
- Coverage     53.09%   52.99%   -0.10%     
+ Complexity     2993     2981      -12     
============================================
  Files          1419     1419              
  Lines         30727    30733       +6     
  Branches       3419     3419              
============================================
- Hits          16315    16288      -27     
- Misses        13612    13643      +31     
- Partials        800      802       +2     
Impacted Files Coverage Δ Complexity Δ
...er/core/server/auth/AuthenticationInterceptor.java 0.00% <0.00%> (-61.54%) 0.00% <0.00%> (-3.00%)
...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...er/sharing/server/ReceiverGRPCHandlerRegister.java 30.76% <0.00%> (-46.16%) 2.00% <0.00%> (-3.00%)
...core/plugin/bytebuddy/AnnotationTypeNameMatch.java 57.14% <0.00%> (-42.86%) 0.00% <0.00%> (ø%)
...ap/server/core/server/GRPCHandlerRegisterImpl.java 62.50% <0.00%> (-25.00%) 2.00% <0.00%> (-1.00%)
...r/cluster/plugin/standalone/StandaloneManager.java 77.77% <0.00%> (-22.23%) 3.00% <0.00%> (-1.00%)
...ing/oap/server/library/server/grpc/GRPCServer.java 55.00% <0.00%> (-5.00%) 6.00% <0.00%> (-1.00%)
.../agent/core/profile/ProfileTaskChannelService.java 47.25% <0.00%> (-3.30%) 9.00% <0.00%> (ø%)
.../server/core/profile/analyze/ProfileStackNode.java 97.24% <0.00%> (-1.84%) 26.00% <0.00%> (-3.00%)
...er/sharing/server/SharingServerModuleProvider.java 37.50% <0.00%> (-1.79%) 8.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f7688...396af78. Read the comment docs.

@wu-sheng wu-sheng added backend OAP backend related. enhancement Enhancement on performance or codes labels Jul 18, 2020
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the PR apache/skywalking-python#35 (review) we need a mapping this time, @alonelaval please add one, refer to line 449 in this file, and thus we don't need a logo then

@alonelaval
Copy link
Copy Markdown
Member Author

As I mentioned in the PR apache/skywalking-python#35 (review) we need a mapping this time, @alonelaval please add one, refer to line 449 in this file, and thus we don't need a logo then

ok.

mariadb-jdbc: Mariadb
Mysqli: Mysql
Predis: Redis
PyMsql: Mysql No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? PyMysql

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? PyMysql

PyMysql

@wu-sheng wu-sheng added this to the 8.1.0 milestone Jul 19, 2020
@wu-sheng wu-sheng merged commit 081c126 into apache:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants