Skip to content

Restore solrj-plugin#2888

Merged
wu-sheng merged 4 commits intoapache:masterfrom
dmsolr:restore-solrj
Jun 17, 2019
Merged

Restore solrj-plugin#2888
wu-sheng merged 4 commits intoapache:masterfrom
dmsolr:restore-solrj

Conversation

@dmsolr
Copy link
Copy Markdown
Member

@dmsolr dmsolr commented Jun 17, 2019

Please answer these questions before submitting pull request

@dmsolr
Copy link
Copy Markdown
Member Author

dmsolr commented Jun 17, 2019

Cases List

Case description Status Cases
solrj 12 passed. 0 failed click me

@wu-sheng wu-sheng added agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Jun 17, 2019
@wu-sheng wu-sheng requested a review from IanCao June 17, 2019 06:48
@wu-sheng wu-sheng added this to the 6.2.0 milestone Jun 17, 2019
@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Jun 17, 2019

@IanCao Could you re-run this, and we could merge this agian.

IanCao
IanCao reviewed Jun 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@IanCao IanCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline

@dmsolr
Copy link
Copy Markdown
Member Author

dmsolr commented Jun 17, 2019

inline

Sorry, @IanCao . I don't really understand what you mean.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Jun 17, 2019

@IanCao I think you miss your comments.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Jun 17, 2019

Here is the test report and validate logs

wu-sheng
wu-sheng approved these changes Jun 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @IanCao Check the codes.

@kezhenxu94 kezhenxu94 self-requested a review June 17, 2019 09:26
@SkyWalkingRobot
Copy link
Copy Markdown

SkyWalkingRobot commented Jun 17, 2019

Here is the test report and validate logs

kezhenxu94
kezhenxu94 requested changes Jun 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline

Comment thread oap-server/server-core/src/test/resources/component-libraries.yml
Comment thread oap-server/server-starter/src/main/resources/component-libraries.yml
IanCao
IanCao approved these changes Jun 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@IanCao IanCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kezhenxu94
kezhenxu94 approved these changes Jun 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it looks good to me

@wu-sheng wu-sheng merged commit 6ff33d8 into apache:master Jun 17, 2019
@dmsolr dmsolr deleted the restore-solrj branch July 16, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@IanCao IanCao IanCao approved these changes

Assignees

No one assigned

Labels

agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dmsolr @wu-sheng @SkyWalkingRobot @kezhenxu94 @IanCao