Conversation
wu-sheng
added
bug
Member
Author
|
@IanCao Please notice this in other review. |
ascrutae
previously approved these changes
Jun 13, 2019
This reverts commit 359990e.
ascrutae
approved these changes
Jun 14, 2019
Member
|
I am so sorry to heard that. I am going to recheck and remove instrumentation of CloseableHttpClient. |
Member
Author
|
@dmsolr we are working on more automatically tests requirements and environments to make this smoothly next time. Instrumentation is one thing. And please don't import the dependency class. Check other plugins, use string name. |
Member
|
I got it. Thank you! |
Member
Author
|
@dmsolr According to our offline discussion, I am looking forward to your script to avoid this happens in the future. |
3 tasks
This was referenced Jun 19, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dmsolr I have to do this emergency revert. This plugin breaks agent, because
import org.apache.http.client.methods.HttpUriRequest;This will break the agent when this doesn't exist.CloseableHttpClientshould not be instrumented by SolrJ plugin, it should be httpClient plugin's responsibility.