Upgrade the InfluxDB storage-plugin to protocol V3#4641
Upgrade the InfluxDB storage-plugin to protocol V3#4641wu-sheng merged 29 commits intoapache:masterfrom
Conversation
wu-sheng
left a comment
There was a problem hiding this comment.
I want to discuss about isTag and tagName in the Column annotation.
- When do we need
isTag? - Once the
isTag== true,tagNamecould be a auto generated information, such as in the H2/MySQL storage, index name is auto generation, is there any reason, you can't do this?
The key point is, I want to make the storage more general. Like your comments of this field, Whether the column is stored as Tag on time-series DB., this is very specific, but other all existing annotation attributes are general, only search may be a little closer to the ElasticSearch as it has a better search feature.
Let's discuss this deeper, to find out whether we could reduce them or replace them with more clear name.
Because at the entity annotation level, it should not link to the storage directly so much. Otherwise, anyone wants to add a entity, need to understand all storage implementation, it will increase the bar for the contributors.
|
@kezhenxu94 WDYT about this direction? |
wu-sheng
left a comment
There was a problem hiding this comment.
Let's keep the limited tags today. Once we have time on the performance test, we will have more ideas about the improvements.
Let's add the e2e back.
Codecov Report
@@ Coverage Diff @@
## master #4641 +/- ##
============================================
+ Coverage 49.12% 49.39% +0.27%
- Complexity 2512 2562 +50
============================================
Files 1267 1266 -1
Lines 27577 27699 +122
Branches 3001 3032 +31
============================================
+ Hits 13547 13683 +136
+ Misses 13386 13374 -12
+ Partials 644 642 -2 Continue to review full report at Codecov.
|
kezhenxu94
left a comment
There was a problem hiding this comment.
Please rewrite the docker-compose.yml to extend from the base-compose.yml, these codes should be counted in the code coverage, please refer to other docker-compose.yml or ping me if you have any problem
|
Now, it is ready for review. @mrproliu @wu-sheng @kezhenxu94 |
kezhenxu94
left a comment
There was a problem hiding this comment.
Just review the E2E part, look good to me
wu-sheng
left a comment
There was a problem hiding this comment.
If coverage is on, good to me. I am doing storage interface refactor, So, this would be changed again.
|
@kezhenxu94 , could you help me to see es6 always failed on e2e? I have not modified this partial. (It is also failed on #4666) |
kezhenxu94
left a comment
There was a problem hiding this comment.
The InfluxDB storage test failed, and I believe it's related to the code itself, @dmsolr please confirm through the logs, there're exceptions related to the codes
|
@kezhenxu94 It seems good now, Need your approve |
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com> Co-authored-by: kezhenxu94 <kezhenxu94@163.com> Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
1. Re-balance the workload of plugintests 2. Restore testcases of MySQL, remove on #4641 3. Support user to runs plugin-test on debug mode. It will not remove the log files and actualData.yaml 4. remove paramater 'parallel_run_size' and disable parallel test.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Make 8.0.0 Core available. New protocol and register removed. #4599
Add influx db as an available storage option again. #4615