Skip to content

[test/plugin] Enhance PluginTest#4677

Merged
wu-sheng merged 8 commits intoapache:masterfrom
dmsolr:test/plugin
Apr 22, 2020
Merged

[test/plugin] Enhance PluginTest#4677
wu-sheng merged 8 commits intoapache:masterfrom
dmsolr:test/plugin

Conversation

@dmsolr
Copy link
Copy Markdown
Member

@dmsolr dmsolr commented Apr 20, 2020

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Enhancement

  • Related issues


New feature or improvement

  1. Re-balance the workload of plugintests
  2. Restore testcases of MySQL, remove on Upgrade the InfluxDB storage-plugin to protocol V3 #4641
  3. Support user to runs plugin-test on debug mode. It will not remove the log files and actualData.yaml
  4. remove paramater 'parallel_run_size' and disable parallel test.

@dmsolr dmsolr changed the title [est/plugin] Enhance PluginTest [WIP][test/plugin] Enhance PluginTest Apr 20, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 20, 2020

Codecov Report

Merging #4677 into master will decrease coverage by 15.55%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #4677       +/-   ##
=============================================
- Coverage     50.85%   35.30%   -15.56%     
+ Complexity     2665     1846      -819     
=============================================
  Files           722      717        -5     
  Lines         17800    17727       -73     
  Branches       1709     1694       -15     
=============================================
- Hits           9053     6258     -2795     
- Misses         8020    11047     +3027     
+ Partials        727      422      -305     
Impacted Files Coverage Δ Complexity Δ
...ywalking/apm/agent/core/logging/core/LogLevel.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ywalking/apm/agent/core/plugin/EnhanceContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...ywalking/apm/agent/core/profile/ProfileStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/context/SW8CarrierItem.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/logging/core/LogOutput.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/plugin/match/NameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...alking/apm/agent/core/context/CarrierItemHead.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...alking/apm/agent/core/jvm/gc/ParallelGCModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...lking/apm/agent/core/remote/GRPCChannelStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e82141...3604e5e. Read the comment docs.

@dmsolr dmsolr changed the title [WIP][test/plugin] Enhance PluginTest [test/plugin] Enhance PluginTest Apr 22, 2020
@dmsolr dmsolr requested review from asf-gitbox, kezhenxu94, rainbend and wu-sheng and removed request for asf-gitbox April 22, 2020 09:25
@dmsolr dmsolr added the test Test requirements about performance, feature or before release. label Apr 22, 2020
@dmsolr dmsolr added this to the 8.0.0 milestone Apr 22, 2020
@kezhenxu94
Copy link
Copy Markdown
Member

Re-balance the workload of plugintests

I don't think we need this and you actually cannot "rebalance" them, as we're using matrix build, all the plugin tests of each plugin are run parallelly , no mater which workflow they belong to

Comment thread .github/workflows/plugins-test.0.yaml
@kezhenxu94
Copy link
Copy Markdown
Member

Re-balance the workload of plugintests

I don't think we need this and you actually cannot "rebalance" them, as we're using matrix build, all the plugin tests of each plugin are run parallelly , no mater which workflow they belong to

The time it costs only depends on the version numbers of the plugin test and the test itself

Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have MySQL cases back.

@wu-sheng wu-sheng merged commit 44f1b4a into apache:master Apr 22, 2020
@dmsolr dmsolr deleted the test/plugin branch April 22, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Test requirements about performance, feature or before release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants