Skip to content

Update Plugin-test.md#4708

Closed
BFergerson wants to merge 1 commit intoapache:masterfrom
BFergerson:patch-1
Closed

Update Plugin-test.md#4708
BFergerson wants to merge 1 commit intoapache:masterfrom
BFergerson:patch-1

Conversation

@BFergerson
Copy link
Copy Markdown
Member

Made it a bit more obvious entryService is GET and healthCheck is HEAD.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 24, 2020

Codecov Report

Merging #4708 into master will decrease coverage by 22.67%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #4708       +/-   ##
=============================================
- Coverage     50.93%   28.25%   -22.68%     
=============================================
  Files           722     1211      +489     
  Lines         17800    26523     +8723     
  Branches       1709     3303     +1594     
=============================================
- Hits           9066     7495     -1571     
- Misses         7999    18351    +10352     
+ Partials        735      677       -58     
Impacted Files Coverage Δ Complexity Δ
...he/skywalking/oal/rt/output/DispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...skywalking/oal/rt/output/AllDispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ache/skywalking/oap/server/core/source/Source.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...che/skywalking/oap/server/core/source/Service.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...he/skywalking/oap/server/core/source/Endpoint.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...he/skywalking/oap/server/core/source/GCPhrase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...e/skywalking/oap/server/core/CoreModuleConfig.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../skywalking/oap/server/core/alarm/AlarmModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...skywalking/oap/server/core/alarm/AlarmMessage.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...skywalking/oap/server/core/source/RequestType.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 1196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776d508...8b1981a. Read the comment docs.

@wu-sheng
Copy link
Copy Markdown
Member

@BFergerson How about review #4706, I think more changes happen there.

@wu-sheng wu-sheng added the TBD To be decided later, need more discussion or input. label Apr 24, 2020
@wu-sheng wu-sheng added this to the 8.0.0 milestone Apr 24, 2020
@BFergerson BFergerson closed this Apr 24, 2020
@BFergerson BFergerson deleted the patch-1 branch April 24, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TBD To be decided later, need more discussion or input.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants