Skip to content

Modification Plugin-test.md#4706

Merged
dmsolr merged 6 commits intoapache:masterfrom
rainbend:fix-doc
Apr 25, 2020
Merged

Modification Plugin-test.md#4706
dmsolr merged 6 commits intoapache:masterfrom
rainbend:fix-doc

Conversation

@rainbend
Copy link
Copy Markdown
Member

@rainbend rainbend added the documentation Provide documents related issue or pull request only. label Apr 24, 2020
@rainbend rainbend added this to the 8.0.0 milestone Apr 24, 2020
@rainbend rainbend requested a review from dmsolr April 24, 2020 12:02
Comment thread docs/en/guides/Plugin-test.md Outdated
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more changes should be done, ref #4628

Could you go through this doc, and fix in this PR too?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 24, 2020

Codecov Report

Merging #4706 into master will decrease coverage by 11.43%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #4706       +/-   ##
=============================================
- Coverage     51.10%   39.67%   -11.44%     
+ Complexity     2690     1484     -1206     
=============================================
  Files          1284     1280        -4     
  Lines         27926    27833       -93     
  Branches       3018     3022        +4     
=============================================
- Hits          14272    11042     -3230     
- Misses        13011    16129     +3118     
- Partials        643      662       +19     
Impacted Files Coverage Δ Complexity Δ
...kywalking/oap/server/core/storage/AbstractDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...ywalking/apm/agent/core/plugin/EnhanceContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...walking/apm/agent/core/plugin/match/NameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ng/oap/server/core/analysis/config/NoneStream.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../apm/agent/core/remote/StandardChannelBuilder.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...server/storage/plugin/influxdb/base/RecordDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...hance/ClassInstanceMethodsEnhancePluginDefine.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...er/storage/plugin/influxdb/base/NoneStreamDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...erver/storage/plugin/elasticsearch/base/EsDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...storage/plugin/influxdb/base/InfluxStorageDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4acf0eb...5b2b598. Read the comment docs.

@rainbend
Copy link
Copy Markdown
Member Author

I think more changes should be done, ref #4628

Could you go through this doc, and fix in this PR too?

Updated.

@rainbend rainbend linked an issue Apr 24, 2020 that may be closed by this pull request
@wu-sheng wu-sheng mentioned this pull request Apr 24, 2020
@wu-sheng
Copy link
Copy Markdown
Member

@BFergerson I can't choose you as a reviewer in the repo, could you have the 3 steps all checked on this page? https://gitbox.apache.org/setup/

@BFergerson
Copy link
Copy Markdown
Member

@wu-sheng, these changes work too. All 3 steps are checked now

@wu-sheng
Copy link
Copy Markdown
Member

@BFergerson Strange, I can't choose you as reviewers, and you are not a part of SkyWalking committer team. https://github.com/orgs/apache/teams/skywalking-committers/members

Could you provide a screenshot about the content at the bottom of the page, about which repos you have write access after 3 steps checked?

@wu-sheng wu-sheng requested a review from BFergerson April 24, 2020 23:38
Comment thread docs/en/guides/Plugin-test.md Outdated
Comment thread docs/en/guides/Plugin-test.md Outdated
@BFergerson
Copy link
Copy Markdown
Member

lgtm

Copy link
Copy Markdown
Member

@dmsolr dmsolr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rainbend
Copy link
Copy Markdown
Member Author

rainbend commented Apr 25, 2020

image
@BFergerson If you think good, should submit the Approve.

@dmsolr
Copy link
Copy Markdown
Member

dmsolr commented Apr 25, 2020

Has some plugin test failed, I am sure it no matter about this update.

@dmsolr dmsolr merged commit 0babc1a into apache:master Apr 25, 2020
@rainbend rainbend deleted the fix-doc branch April 25, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the document of agent test.

5 participants