Skip to content

Increase Vert.x Compatability#4736

Merged
dmsolr merged 39 commits intoapache:masterfrom
BFergerson:master
May 1, 2020
Merged

Increase Vert.x Compatability#4736
dmsolr merged 39 commits intoapache:masterfrom
BFergerson:master

Conversation

@BFergerson
Copy link
Copy Markdown
Member


New feature or improvement

#4624 just added the Vert.x tests back to the main repository. Those test weren't entirely correct as they were missing segments but I just wanted to get them back in the repo and fix in another PR. This is that PR. This PR also increases the compatibility for Vert.x Eventbus/Web to 3.9.0.

@BFergerson BFergerson linked an issue Apr 29, 2020 that may be closed by this pull request
3 tasks
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 29, 2020

Codecov Report

Merging #4736 into master will decrease coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4736      +/-   ##
============================================
- Coverage     50.78%   50.26%   -0.52%     
+ Complexity     2648     2644       -4     
============================================
  Files          1287      726     -561     
  Lines         28105    17945   -10160     
  Branches       3065     1735    -1330     
============================================
- Hits          14272     9020    -5252     
+ Misses        13186     8197    -4989     
- Partials        647      728      +81     
Impacted Files Coverage Δ Complexity Δ
.../agent/core/context/trace/AbstractTracingSpan.java 40.56% <0.00%> (-24.86%) 13.00 <0.00> (ø)
...p/server/core/analysis/metrics/MinLongMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/exporter/provider/grpc/GRPCExporterSetting.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...king/oap/server/configuration/api/ConfigTable.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...skywalking/oap/server/receiver/envoy/als/Role.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../server/receiver/envoy/als/DependencyResource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...erver/cluster/plugin/consul/ConsulCoordinator.java 0.00% <0.00%> (-97.15%) 0.00% <0.00%> (ø%)
...uster/plugin/kubernetes/KubernetesCoordinator.java 0.00% <0.00%> (-94.45%) 0.00% <0.00%> (ø%)
.../analysis/transform/Zipkin2SkyWalkingTransfer.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (ø%)
... and 864 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64232f8...64232f8. Read the comment docs.

@wu-sheng wu-sheng mentioned this pull request Apr 30, 2020
3 tasks
@wu-sheng wu-sheng added agent Language agent related. enhancement Enhancement on performance or codes plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Apr 30, 2020
@wu-sheng wu-sheng added this to the 8.0.0 milestone Apr 30, 2020
dmsolr
dmsolr previously approved these changes Apr 30, 2020
Copy link
Copy Markdown
Member

@dmsolr dmsolr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BFergerson
Copy link
Copy Markdown
Member Author

@wu-sheng, the test that's failing is from another plugin. Is there anything I need to do to resolve this?

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented May 1, 2020

I am rerunning them, should be nothing related to this PR. Just unstable tests.

@dmsolr dmsolr merged commit 4fc57a6 into apache:master May 1, 2020
@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented May 1, 2020

@dmsolr Please reorganize the commit log as this PR has a long commit logs, not good for squash merge.

@BFergerson I think you missed the supported list doc update? You added the new versions, I haven't checked whether should update that doc.

@BFergerson
Copy link
Copy Markdown
Member Author

@wu-sheng, supported list doc already mentions support for 3.x. Now it's even more true

@dmsolr
Copy link
Copy Markdown
Member

dmsolr commented May 1, 2020

Sorry. I got

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Language agent related. enhancement Enhancement on performance or codes plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vert.x plugin can not boot

5 participants