SOLR-17956 Deprecate the XLSXResponseWriter in v9.10 #3769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the XLSXResponseWriter class in Solr v9.10 as indicated by JIRA ticket SOLR-17956. The deprecation includes proper documentation updates and follows established deprecation practices.
Key changes:
- Added
@Deprecatedannotation to XLSXResponseWriter class with removal flag - Updated documentation to inform users about the deprecation
- Added change log entry documenting the deprecation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| XLSXResponseWriter.java | Added deprecation annotation and updated javadoc to indicate future removal |
| response-writers.adoc | Added important notice about XLSXResponseWriter deprecation |
| major-changes-in-solr-9.adoc | Added deprecations section documenting XLSXResponseWriter deprecation |
| CHANGES.txt | Added changelog entry for the deprecation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
epugh
approved these changes
Oct 14, 2025
janhoy
force-pushed
the
SOLR-17956-deprecate-XLSXResponseWriter
branch
from
9989938 to
780001a
Compare
janhoy
added a commit
that referenced
this pull request
Oct 15, 2025
(cherry picked from commit dead9b6)
janhoy
added a commit
that referenced
this pull request
Oct 15, 2025
(cherry picked from commit dead9b6)
janhoy
added a commit
to janhoy/solr
that referenced
this pull request
Oct 15, 2025
Backported from main branch dead9b6 Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17956