Skip to content

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Oct 14, 2025

https://issues.apache.org/jira/browse/SOLR-17957

This PR sits on top of #3769 and that one must be merged to main first

@github-actions github-actions bot added documentation Improvements or additions to documentation module:extraction tests labels Oct 14, 2025
@janhoy janhoy marked this pull request as draft October 14, 2025 22:49
@janhoy janhoy requested a review from Copilot October 14, 2025 22:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the deprecated XLSX Response Writer from Solr as part of SOLR-17957, cleaning up code, tests, and documentation.

  • Drops XLSXResponseWriter implementation and its tests from the extraction module
  • Removes dynamic registration of wt=xlsx from SolrCore
  • Updates documentation: removes XLSX references from the Query Guide, adds an Upgrade Note, and updates CHANGES.txt

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
solr/modules/extraction/src/java/org/apache/solr/handler/extraction/XLSXResponseWriter.java Removes the XLSXResponseWriter implementation.
solr/modules/extraction/src/test/org/apache/solr/handler/extraction/TestXLSXResponseWriter.java Removes unit tests tied to the XLSX writer.
solr/core/src/java/org/apache/solr/core/SolrCore.java Removes dynamic registration of the xlsx writer from DEFAULT_RESPONSE_WRITERS.
solr/solr-ref-guide/modules/query-guide/pages/response-writers.adoc Removes XLSX from the documented response writers and deletes the XLSX section.
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc Adds an Upgrade Note announcing removal and migration guidance.
solr/CHANGES.txt Adds an entry under Deprecation Removals noting the XLSX writer removal.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@janhoy janhoy force-pushed the SOLR-17956-deprecate-XLSXResponseWriter branch from 9989938 to 780001a Compare October 15, 2025 12:59
@janhoy janhoy force-pushed the SOLR-17957-remove-XLSXResponseWriter branch from f1cad16 to 20e9985 Compare October 15, 2025 14:35
@github-actions github-actions bot removed the tests label Oct 15, 2025
@janhoy janhoy deleted the branch apache:SOLR-17956-deprecate-XLSXResponseWriter October 15, 2025 20:30
@janhoy janhoy closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation module:extraction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant