[SPARK-14086][SQL] Add DDL commands to ANTLR4 parser #12011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #54354 has finished for PR 12011 at commit
|
This was referenced Mar 28, 2016
|
Test build #54359 has finished for PR 12011 at commit
|
|
Test build #2704 has finished for PR 12011 at commit
|
Contributor
|
LGTM pretty straightforward. Let's do the improvements in followup PRs. |
Contributor
|
Merging into master. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Mar 29, 2016
### What changes were proposed in this pull request? This PR migrates all HiveQl parsing to the new ANTLR4 parser. This PR is build on top of apache#12011, and we should wait with merging until that one is in (hence the WIP tag). As soon as this PR is merged we can start removing much of the old parser infrastructure. ### How was this patch tested? Exisiting Hive unit tests. cc rxin andrewor14 yhuai Author: Herman van Hovell <hvanhovell@questtec.nl> Closes apache#12015 from hvanhovell/SPARK-14213.
Contributor
|
@hvanhovell can you create a jira ticket for the follow-up tasks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds all the current Spark SQL DDL commands to the new ANTLR 4 based SQL parser.
I have found a few inconsistencies in the current commands:
Nones in others.AlterTableSkewedLocation: Should defines which columns have skewed values, and should allow us to define storage for each skewed combination of values. We currently only allow one value per field.AlterTableSetFileFormat: Should only have one file format, it currently supports both.I have implemented all these comments like they were, and I propose to improve them in follow-up PRs.
How was this patch tested?
The existing DDLCommandSuite.
cc @rxin @andrewor14 @yhuai