[SPARK-14213][SQL] Migrate HiveQl parsing to ANTLR4 parser #12015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
changed the title
|
Test build #54367 has finished for PR 12015 at commit
|
|
Test build #54381 has finished for PR 12015 at commit
|
|
Test build #54392 has finished for PR 12015 at commit
|
Contributor
|
Thanks - I've merged this in master. |
This was referenced Mar 29, 2016
| properties = properties, | ||
| viewOriginalText = sql, | ||
| viewText = sql) | ||
| CreateView(tableDesc, plan(query), allowExist, replace, command(ctx)) |
Member
There was a problem hiding this comment.
@hvanhovell I search the whole code base, but still unable to find the implementation of this class CreateView? I am just wondering how scala Compiler can recognize it? Thanks!
Contributor
Author
There was a problem hiding this comment.
@gatorsmile I renamed the import to CreateView. The actual class is org.apache.spark.sql.hive.CreateViewAsSelect. See the following line in HiveSqlParser:
import org.apache.spark.sql.hive.{CreateTableAsSelect => CTAS, CreateViewAsSelect => CreateView}
Member
There was a problem hiding this comment.
NVM, CreateViewAsSelect => CreateView. I found it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR migrates all HiveQl parsing to the new ANTLR4 parser. This PR is build on top of #12011, and we should wait with merging until that one is in (hence the WIP tag).
As soon as this PR is merged we can start removing much of the old parser infrastructure.
How was this patch tested?
Exisiting Hive unit tests.
cc @rxin @andrewor14 @yhuai