Skip to content

Conversation

@seyfe
Copy link
Contributor

@seyfe seyfe commented Oct 4, 2016

What changes were proposed in this pull request?

Added VoidObjectInspector to the list of PrimitiveObjectInspectors

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Executing following query was failing.
select SOME_UDAF*(a.arr)
from (
select Array(null) as arr from dim_one_row
) a

After the fix, I am getting the correct output:
res0: Array[org.apache.spark.sql.Row] = Array([null])

@hvanhovell
Copy link
Contributor

ok to test

@hvanhovell
Copy link
Contributor

hvanhovell commented Oct 4, 2016

@seyfe This seems like a good idea. Could you add a little test to see if this is working?

@SparkQA
Copy link

SparkQA commented Oct 4, 2016

Test build #66290 has finished for PR 15337 at commit 2c18d75.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@seyfe
Copy link
Contributor Author

seyfe commented Oct 4, 2016

@hvanhovell. Thanks for the suggestion.

Updated the HiveInspectorSuite, so 3 tests failed with below error:
org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaVoidObjectInspector@7f485fda (of class org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaVoidObjectInspector) scala.MatchError: org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaVoidObjectInspector@7f485fda (of class org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaVoidObjectInspector)

After applying the fix, all HiveInspectorSuite tests passed.

@SparkQA
Copy link

SparkQA commented Oct 4, 2016

Test build #66299 has finished for PR 15337 at commit ce0174f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Oct 4, 2016

Thanks - merging in master/2.0.

@rxin
Copy link
Contributor

rxin commented Oct 4, 2016

Actually there is a conflict with back porting this into branch-2.0. Do you mind making a pull request against branch-2.0 too?

@asfgit asfgit closed this in d2dc8c4 Oct 4, 2016
seyfe added a commit to seyfe/spark that referenced this pull request Oct 4, 2016
Added VoidObjectInspector to the list of PrimitiveObjectInspectors

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Executing following query was failing.
select SOME_UDAF*(a.arr)
from (
select Array(null) as arr from dim_one_row
) a

After the fix, I am getting the correct output:
res0: Array[org.apache.spark.sql.Row] = Array([null])

Author: Ergin Seyfe <eseyfe@fb.com>

Closes apache#15337 from seyfe/add_void_object_inspector.
@seyfe
Copy link
Contributor Author

seyfe commented Oct 4, 2016

Thanks @rxin. I created a PR for branch-2.0.
#15345

@seyfe seyfe deleted the add_void_object_inspector branch October 4, 2016 19:45
asfgit pushed a commit that referenced this pull request Oct 5, 2016
This is the PR for branch2.0: PR #15337

Added VoidObjectInspector to the list of PrimitiveObjectInspectors

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Executing following query was failing.
select SOME_UDAF*(a.arr)
from (
select Array(null) as arr from dim_one_row
) a

After the fix, I am getting the correct output:
res0: Array[org.apache.spark.sql.Row] = Array([null])

Author: Ergin Seyfe <eseyfefb.com>

Closes #15337 from seyfe/add_void_object_inspector.

Author: Ergin Seyfe <eseyfe@fb.com>

Closes #15345 from seyfe/add_void_object_inspector_2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants