Skip to content

Conversation

@seyfe
Copy link
Contributor

@seyfe seyfe commented Oct 4, 2016

This is the PR for branch2.0: PR #15337

Added VoidObjectInspector to the list of PrimitiveObjectInspectors

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Executing following query was failing.
select SOME_UDAF*(a.arr)
from (
select Array(null) as arr from dim_one_row
) a

After the fix, I am getting the correct output:
res0: Array[org.apache.spark.sql.Row] = Array([null])

Author: Ergin Seyfe eseyfe@fb.com

Closes #15337 from seyfe/add_void_object_inspector.

Added VoidObjectInspector to the list of PrimitiveObjectInspectors

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Executing following query was failing.
select SOME_UDAF*(a.arr)
from (
select Array(null) as arr from dim_one_row
) a

After the fix, I am getting the correct output:
res0: Array[org.apache.spark.sql.Row] = Array([null])

Author: Ergin Seyfe <eseyfe@fb.com>

Closes apache#15337 from seyfe/add_void_object_inspector.
@hvanhovell
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Oct 4, 2016

Test build #66326 has finished for PR 15345 at commit 68c59f1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM - merging to 2.0. Thanks!

Could you close this PR? (our merge tooling does not close backports automatically)

@seyfe
Copy link
Contributor Author

seyfe commented Oct 4, 2016

Closing as requested by @hvanhovell

@seyfe seyfe closed this Oct 4, 2016
@seyfe seyfe deleted the add_void_object_inspector_2.0 branch October 4, 2016 19:45
asfgit pushed a commit that referenced this pull request Oct 5, 2016
This is the PR for branch2.0: PR #15337

Added VoidObjectInspector to the list of PrimitiveObjectInspectors

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Executing following query was failing.
select SOME_UDAF*(a.arr)
from (
select Array(null) as arr from dim_one_row
) a

After the fix, I am getting the correct output:
res0: Array[org.apache.spark.sql.Row] = Array([null])

Author: Ergin Seyfe <eseyfefb.com>

Closes #15337 from seyfe/add_void_object_inspector.

Author: Ergin Seyfe <eseyfe@fb.com>

Closes #15345 from seyfe/add_void_object_inspector_2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants