[SPARK-25764][ML][EXAMPLES] Update BisectingKMeans example to use ClusteringEvaluator #22763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecated computeCost method
Contributor
Author
|
Test build #97527 has finished for PR 22763 at commit
|
Contributor
|
LGTM. thanks! |
Member
|
Can we use a more positive title, @mgaido91 ? |
mgaido91
changed the title
Contributor
Author
|
done @dongjoon-hyun , thanks. |
Contributor
|
thanks, merging to master/2.4! |
asfgit
pushed a commit
that referenced
this pull request
Oct 19, 2018
…steringEvaluator ## What changes were proposed in this pull request? The PR updates the examples for `BisectingKMeans` so that they don't use the deprecated method `computeCost` (see SPARK-25758). ## How was this patch tested? running examples Closes #22763 from mgaido91/SPARK-25764. Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit d0ecff2) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
|
This has been reverted from master/2.4, since #22756 was reverted |
Member
|
Ur, @mengxr and @gatorsmile seems to determine to revert #22756 on |
Contributor
Author
|
Actually I don't see at all the need to revert this. Even without deprecating |
Contributor
|
ah i see. @mgaido91 can you resubmit it and update the description? The method is not deprecated now. |
Contributor
Author
|
sure, thanks @cloud-fan |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…steringEvaluator ## What changes were proposed in this pull request? The PR updates the examples for `BisectingKMeans` so that they don't use the deprecated method `computeCost` (see SPARK-25758). ## How was this patch tested? running examples Closes apache#22763 from mgaido91/SPARK-25764. Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR updates the examples for
BisectingKMeansso that they don't use the deprecated methodcomputeCost(see SPARK-25758).How was this patch tested?
running examples