[SPARK-25764][ML][EXAMPLES] Update BisectingKMeans example to use ClusteringEvaluator #22786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecated computeCost method
Contributor
Author
|
Test build #97681 has finished for PR 22786 at commit
|
Contributor
|
also cc @WeichenXu123 |
Contributor
Author
|
@dongjoon-hyun , no there aren't differences. I resubmitted in answer to #22763 (comment). Thanks. |
Contributor
Author
|
any comments on this? |
Contributor
Author
Contributor
|
cc @dbtsai |
Member
|
LGTM. Merged into master. Thanks! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…steringEvaluator ## What changes were proposed in this pull request? Using `computeCost` for evaluating a model is a very poor approach. We should advice the users to a better approach which is available, ie. using the `ClusteringEvaluator` to evaluate their models. The PR updates the examples for `BisectingKMeans` in order to do that. ## How was this patch tested? running examples Closes apache#22786 from mgaido91/SPARK-25764. Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by: DB Tsai <d_tsai@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Using
computeCostfor evaluating a model is a very poor approach. We should advice the users to a better approach which is available, ie. using theClusteringEvaluatorto evaluate their models. The PR updates the examples forBisectingKMeansin order to do that.How was this patch tested?
running examples