[SPARK-49190][K8S] Add SPARK_EXECUTOR_ATTRIBUTE_(APP|EXECUTOR)_ID if CUSTOM_EXECUTOR_LOG_URL is defined
#47692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f `CUSTOM_EXECUTOR_LOG_URL` is defined
dongjoon-hyun
commented
Aug 9, 2024
|
|
||
| ``` | ||
| spark.executorEnv.SPARK_EXECUTOR_ATTRIBUTE_APP_ID='$(SPARK_APPLICATION_ID)' | ||
| spark.executorEnv.SPARK_EXECUTOR_ATTRIBUTE_EXECUTOR_ID='$(SPARK_EXECUTOR_ID)' |
Member
Author
There was a problem hiding this comment.
We don't need this from Apache Spark 4.0.0-preview2.
Contributor
There was a problem hiding this comment.
Would be nice to still mention the feature of spark.executorEnv.SPARK_EXECUTOR_ATTRIBUTE_* here of using any Kubernetes environment variable.
Member
Author
There was a problem hiding this comment.
It's irrelevant to this PR because this PR specifically targets Add SPARK_EXECUTOR_ATTRIBUTE_(APP|EXECUTOR)_ID if CUSTOM_EXECUTOR_LOG_URL is defined.
However, of course, you can make a documentation contribution if you want, @EnricoMi . We will review it separately.
Member
Author
|
Could you review this PR, @viirya ? |
viirya
approved these changes
Aug 9, 2024
Member
Author
|
Thank you, @viirya ! |
Member
Author
|
Merged to master for Apache Spark 4.0.0-preview2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
SPARK_EXECUTOR_ATTRIBUTE_(APP|EXECUTOR)_IDifCUSTOM_EXECUTOR_LOG_URLis defined.Why are the changes needed?
Apache Spark has been supported
spark.ui.custom.executor.log.urlin K8s environment well.spark.ui.custom.executor.log.urldocs by adding K8s #47681This PR aims to help users use it more easily by providing the required
SPARK_EXECUTOR_ATTRIBUTE_APP_IDandSPARK_EXECUTOR_ATTRIBUTE_EXECUTOR_IDautomatically ifspark.ui.custom.executor.log.urlis defined.Does this PR introduce any user-facing change?
spark.ui.custom.executor.log.urlis not used.spark.ui.custom.executor.log.urlis used,How was this patch tested?
No.
Was this patch authored or co-authored using generative AI tooling?
No.