[SPARK-49190][K8S][FOLLOW-UP] Add how to populate executor log url vars with env vars #47801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/running-on-kubernetes.md
Outdated
| spark.ui.custom.executor.log.url='https://log-server/log?appId={{APP_ID}}&execId={{EXECUTOR_ID}}' | ||
| ``` | ||
|
|
||
| You can add custom variables to this url template, populated with the values of existing executor environment variables like |
Member
There was a problem hiding this comment.
add custom -> add additional custom
docs/running-on-kubernetes.md
Outdated
| You can add custom variables to this url template, populated with the values of existing executor environment variables like | ||
|
|
||
| ``` | ||
| spark.executorEnv.SPARK_EXECUTOR_ATTRIBUTE_YOUR_VAR='$(EXECUTOR_ENV_VAR)' |
Member
There was a problem hiding this comment.
EXECUTOR_ENV_VAR part looks confusing. According to the above description, EXISTING_EXECUTOR_ENV_VAR could be better.
dongjoon-hyun
approved these changes
Aug 20, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @EnricoMi .
Merged to master~
Contributor
Author
|
Thanks @dongjoon-hyun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Mentions in the docs how to populate custom executor log url vars with environment variable's values.
Why are the changes needed?
This feature exists since 3.0.0 but is not documented elsewhere.
Does this PR introduce any user-facing change?
Improves documentation.
How was this patch tested?
Not tested.
Was this patch authored or co-authored using generative AI tooling?
No.