[SPARK-51164][CORE][TESTS] Fix CallerContext test by enabling hadoop.caller.context.enabled
#49893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op.caller.context.enabled`
cnauroth
approved these changes
Feb 11, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
+1 (non-binding)
This will remove the need for the test helper I proposed on #49858. Thanks, @dongjoon-hyun !
Member
Author
|
Thank you, @cnauroth ! |
cnauroth
reviewed
Feb 11, 2025
| if (CallerContext.callerContextEnabled) { | ||
| assert(s"SPARK_$context" === HadoopCallerContext.getCurrent.toString) | ||
| } | ||
| assert(s"SPARK_$context" === HadoopCallerContext.getCurrent.toString) |
Contributor
There was a problem hiding this comment.
Maybe consider adding an assert-not-null like in the #49858 test? If this isn't working, or if someone disables it in pom.xml, then toString will cause NPE instead of an assertion failure message.
Member
Author
There was a problem hiding this comment.
NPE is already enough to detect the failure. :)
Member
Author
|
Could you review this when you have some time, @sunchao ? |
sunchao
approved these changes
Feb 11, 2025
Member
sunchao
left a comment
sunchao
left a comment
There was a problem hiding this comment.
LGTM, thanks for the ping @dongjoon-hyun
Member
Author
|
Thank you so much, @sunchao ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 11, 2025
…op.caller.context.enabled` ### What changes were proposed in this pull request? This PR aims to fix `CallerContext` test by enabling `hadoop.caller.context.enabled` during tests. ### Why are the changes needed? This test case was disabled since Apache Spark 2.1.0 because `CallerContext` was supported since Apache Hadoop 2.8+. - #15377 We need to recover `CallerContext` test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49893 from dongjoon-hyun/SPARK-51164. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d07b560) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 11, 2025
…op.caller.context.enabled` ### What changes were proposed in this pull request? This PR aims to fix `CallerContext` test by enabling `hadoop.caller.context.enabled` during tests. ### Why are the changes needed? This test case was disabled since Apache Spark 2.1.0 because `CallerContext` was supported since Apache Hadoop 2.8+. - #15377 We need to recover `CallerContext` test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49893 from dongjoon-hyun/SPARK-51164. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d07b560) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Contributor
|
@dongjoon-hyun and @sunchao , FYI, this might need a small follow-up: #49898 . Thank you. |
Member
Author
|
Ack, @cnauroth . |
Contributor
|
ok, so with this #49779 doesn't need the changes in the production code, it can just
happy |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…op.caller.context.enabled` ### What changes were proposed in this pull request? This PR aims to fix `CallerContext` test by enabling `hadoop.caller.context.enabled` during tests. ### Why are the changes needed? This test case was disabled since Apache Spark 2.1.0 because `CallerContext` was supported since Apache Hadoop 2.8+. - apache#15377 We need to recover `CallerContext` test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49893 from dongjoon-hyun/SPARK-51164. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 9edaf80) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
CallerContexttest by enablinghadoop.caller.context.enabledduring tests.Why are the changes needed?
This test case was disabled since Apache Spark 2.1.0 because
CallerContextwas supported since Apache Hadoop 2.8+.We need to recover
CallerContexttest coverage.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.