-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-51164][CORE][TESTS][FOLLOWUP] Add hadoop.caller.context.enabled for scalatest-maven-plugin. #49898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…atest-maven-plugin. ### What changes were proposed in this pull request? Apply previous SPARK-51164 fix to `mvn test` invocations of scalatest-maven-plugin. ### Why are the changes needed? I found that the previous SPARK-51164 fix was working well for `sbt` test invocations. However, I was seeing `UtilsSuite` fail when invoked through `mvn`. The previous fix applied the `hadoop.caller.context.enabled` configuration to the Java tests run through maven-surefire-plugin. This patch applies the same change for the Scala tests run through scalatest-maven-plugin. ### Does this PR introduce _any_ user-facing change? No. This change only impacts tests. ### How was this patch tested? ``` build/mvn -o -pl core test -Dtest=none -Dsuites=org.apache.spark.util.UtilsSuite Run completed in 8 seconds, 900 milliseconds. Total number of tests run: 61 Suites: completed 1, aborted 0 Tests: succeeded 61, failed 0, canceled 0, ignored 0, pending 0 All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No.
| <derby.system.durability>test</derby.system.durability> | ||
| <java.awt.headless>true</java.awt.headless> | ||
| <java.io.tmpdir>${project.build.directory}/tmp</java.io.tmpdir> | ||
| <spark.hadoop.hadoop.caller.context.enabled>true</spark.hadoop.hadoop.caller.context.enabled> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. So, previously, I added this to maven-surefire-plugin only and missed scalatest-maven-plugin. Thank you, @cnauroth !
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Since the PR builder is SBT, I verified manually. |
…d for scalatest-maven-plugin ### What changes were proposed in this pull request? Apply previous SPARK-51164 fix to `mvn test` invocations of scalatest-maven-plugin. ### Why are the changes needed? I found that the previous SPARK-51164 fix was working well for `sbt` test invocations. However, I was seeing `UtilsSuite` fail when invoked through `mvn`. The previous fix applied the `hadoop.caller.context.enabled` configuration to the Java tests run through maven-surefire-plugin. This patch applies the same change for the Scala tests run through scalatest-maven-plugin. ### Does this PR introduce _any_ user-facing change? No. This change only impacts tests. ### How was this patch tested? ``` build/mvn -o -pl core test -Dtest=none -Dsuites=org.apache.spark.util.UtilsSuite Run completed in 8 seconds, 900 milliseconds. Total number of tests run: 61 Suites: completed 1, aborted 0 Tests: succeeded 61, failed 0, canceled 0, ignored 0, pending 0 All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49898 from cnauroth/SPARK-51164-mvn-scalatest. Authored-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit e2c81ad) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…d for scalatest-maven-plugin ### What changes were proposed in this pull request? Apply previous SPARK-51164 fix to `mvn test` invocations of scalatest-maven-plugin. ### Why are the changes needed? I found that the previous SPARK-51164 fix was working well for `sbt` test invocations. However, I was seeing `UtilsSuite` fail when invoked through `mvn`. The previous fix applied the `hadoop.caller.context.enabled` configuration to the Java tests run through maven-surefire-plugin. This patch applies the same change for the Scala tests run through scalatest-maven-plugin. ### Does this PR introduce _any_ user-facing change? No. This change only impacts tests. ### How was this patch tested? ``` build/mvn -o -pl core test -Dtest=none -Dsuites=org.apache.spark.util.UtilsSuite Run completed in 8 seconds, 900 milliseconds. Total number of tests run: 61 Suites: completed 1, aborted 0 Tests: succeeded 61, failed 0, canceled 0, ignored 0, pending 0 All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49898 from cnauroth/SPARK-51164-mvn-scalatest. Authored-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit e2c81ad) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/4.0/3.5. |
|
Thank you again, @cnauroth , and sorry for the trouble on Maven testing. :) |
|
@dongjoon-hyun , thanks for the quick approval and merge. No worries! |
…d for scalatest-maven-plugin ### What changes were proposed in this pull request? Apply previous SPARK-51164 fix to `mvn test` invocations of scalatest-maven-plugin. ### Why are the changes needed? I found that the previous SPARK-51164 fix was working well for `sbt` test invocations. However, I was seeing `UtilsSuite` fail when invoked through `mvn`. The previous fix applied the `hadoop.caller.context.enabled` configuration to the Java tests run through maven-surefire-plugin. This patch applies the same change for the Scala tests run through scalatest-maven-plugin. ### Does this PR introduce _any_ user-facing change? No. This change only impacts tests. ### How was this patch tested? ``` build/mvn -o -pl core test -Dtest=none -Dsuites=org.apache.spark.util.UtilsSuite Run completed in 8 seconds, 900 milliseconds. Total number of tests run: 61 Suites: completed 1, aborted 0 Tests: succeeded 61, failed 0, canceled 0, ignored 0, pending 0 All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49898 from cnauroth/SPARK-51164-mvn-scalatest. Authored-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 03d264e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
Apply previous SPARK-51164 fix to
mvn testinvocations of scalatest-maven-plugin.Why are the changes needed?
I found that the previous SPARK-51164 fix was working well for
sbttest invocations. However, I was seeingUtilsSuitefail when invoked throughmvn. The previous fix applied thehadoop.caller.context.enabledconfiguration to the Java tests run through maven-surefire-plugin. This patch applies the same change for the Scala tests run through scalatest-maven-plugin.Does this PR introduce any user-facing change?
No. This change only impacts tests.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.