Skip to content

[SPARK-51420][SQL][FOLLOWUP] Support all valid TIME precisions in the minute function #50551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the-sakthi wants to merge 1 commit into from
Closed

[SPARK-51420][SQL][FOLLOWUP] Support all valid TIME precisions in the minute function #50551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ case class MinutesOfTime(child: Expression)
Seq(child.dataType)
)

override def inputTypes: Seq[AbstractDataType] = Seq(TimeType())
override def inputTypes: Seq[AbstractDataType] =
Seq(TypeCollection(TimeType.MIN_PRECISION to TimeType.MAX_PRECISION map TimeType: _*))

override def children: Seq[Expression] = Seq(child)

Expand Down
13 changes: 12 additions & 1 deletion ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,22 @@ class TimeExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
"docroot" -> SPARK_DOC_ROOT)
)

// test TIME-typed child should build MinutesOfTime
// test TIME-typed child should build MinutesOfTime for default precision value
val timeExpr = Literal(localTime(12, 58, 59), TimeType())
val builtExprForTime = MinuteExpressionBuilder.build("minute", Seq(timeExpr))
assert(builtExprForTime.isInstanceOf[MinutesOfTime])
assert(builtExprForTime.asInstanceOf[MinutesOfTime].child eq timeExpr)
assert(builtExprForTime.checkInputDataTypes().isSuccess)

// test TIME-typed child should build MinutesOfTime for all allowed custom precision values
(TimeType.MIN_PRECISION to TimeType.MICROS_PRECISION).foreach { precision =>
val timeExpr = Literal(localTime(12, 58, 59), TimeType(precision))
val builtExpr = MinuteExpressionBuilder.build("minute", Seq(timeExpr))

assert(builtExpr.isInstanceOf[MinutesOfTime])
assert(builtExpr.asInstanceOf[MinutesOfTime].child eq timeExpr)
assert(builtExpr.checkInputDataTypes().isSuccess)
}

// test non TIME-typed child should build Minute
val tsExpr = Literal("2009-07-30 12:58:59")
Expand Down