refactor: remove queryFields in QueryObject and update chart control configs#12091
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12091 +/- ##
==========================================
- Coverage 67.19% 63.06% -4.13%
==========================================
Files 994 994
Lines 49079 49067 -12
Branches 4982 4983 +1
==========================================
- Hits 32977 30945 -2032
- Misses 15980 17922 +1942
- Partials 122 200 +78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktmud
force-pushed
the
query-object-params
branch
4 times, most recently
from
6e82bca to
01f9f72
Compare
villebro
approved these changes
Dec 19, 2020
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM, thanks for ripping this out!
ktmud
force-pushed
the
query-object-params
branch
2 times, most recently
from
ae3ab25 to
54a7f84
Compare
ktmud
changed the title
ktmud
force-pushed
the
query-object-params
branch
from
54a7f84 to
c58eae2
Compare
Member
|
Looks like the failed cypress tests are causing errors on unrelated PRs. I'll restart a few times to see if they're just flaky. |
ktmud
force-pushed
the
query-object-params
branch
from
c58eae2 to
9b30284
Compare
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
…configs (apache#12091) * Clean up queryFields * Clean up unused vars * Bump chart plugins * Bringing changes in apache#12147
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
…configs (apache#12091) * Clean up queryFields * Clean up unused vars * Bump chart plugins * Bringing changes in apache#12147
This was referenced Jan 15, 2021
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…configs (apache#12091) * Clean up queryFields * Clean up unused vars * Bump chart plugins * Bringing changes in apache#12147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove
queryFieldsfromformDataandqueryContextas per discussion in #9962 (comment)Requires apache-superset/superset-ui#862
Also brings changes in #12147
to bundle the breaking changes into one working PR.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
No functional changes, all CI should pass
ADDITIONAL INFORMATION