fix(explore): time table control panel by ktmud · Pull Request #12532 · apache/superset

ktmud · 2021-01-15T02:28:33Z

SUMMARY

Currently Time Table is broken because recent updates on the Time Column control ( apache-superset/superset-ui#869 ) didn't apply to the actual Time Table plugin code used in superset-frontend.

This is because Time Table vis hasn't been fully migrated to superset-ui. This PR ports the necessary change to the control panel to superset-frontend. Tried to do the full migration, but the viz is broken in a separate way. Obviously the migrated plugin @superset-ui/legacy-plugin-chart-time-table doesn't really work.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Time controls are not visible for viz type "Time Table", and an error:

Datetime column not provided as part table configuration and is required by this type of chart

After

Time table works as expected.

TEST PLAN

Try create or edit a time table chart.

ADDITIONAL INFORMATION

Has associated issue: [WIP] chore(explore): remove dedicated time section #12147 refactor: remove queryFields in QueryObject and update chart control configs #12091 (when the regression is actually merged) chore(chart-controls): remove dedicated time section apache-superset/superset-ui#869
Changes UI
Requires DB Migration.
Confirm DB Migration upgrade and downgrade tested.
Introduces new feature or API
Removes existing feature or API

zhaoyongjie

LGTM, thanks for your quick fix.

codecov-io · 2021-01-15T02:38:42Z

Codecov Report

Merging #12532 (4062fc3) into master (3f3a2ad) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12532      +/-   ##
==========================================
- Coverage   66.72%   66.64%   -0.09%     
==========================================
  Files        1014     1014              
  Lines       49612    49612              
  Branches     4839     4839              
==========================================
- Hits        33106    33065      -41     
- Misses      16383    16424      +41     
  Partials      123      123

Flag	Coverage Δ
cypress	`50.98% <ø> (+<0.01%)`	⬆️
javascript	`60.73% <ø> (ø)`
python	`63.78% <ø> (-0.14%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/presto.py	`73.37% <0.00%> (-8.66%)`	⬇️
...set-frontend/src/dashboard/util/getDropPosition.js	`92.06% <0.00%> (-1.59%)`	⬇️
superset/models/core.py	`88.58% <0.00%> (-0.28%)`	⬇️
...rset-frontend/src/explore/components/SaveModal.tsx	`91.76% <0.00%> (+1.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3a2ad...4062fc3. Read the comment docs.

junlincc · 2021-01-15T02:40:03Z

@ktmud 🙏

ktmud · 2021-01-15T02:43:29Z

@junlincc I created a follow up ticket: #12533 , could you assign someone to it?

junlincc · 2021-01-15T03:03:01Z

@junlincc I created a follow up ticket: #12533 , could you assign someone to it?

yes.
is filter box also missing time section? （let me try）.. @ktmud

ktmud · 2021-01-15T04:35:59Z

is filter box also missing time section? （let me try）.. @ktmud

It's true, FilterBox also need a fix. Let me make another PR.

* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (#12391) * chore: Fix typo “Rest” to “Reset” (#12392) * chore: upgrade eslint, babel, and prettier (#12393) * feat(explore): add tooltip to timepicker label (#12401) * chore: change Datasource to Dataset in Explore ui (#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback * fix: Refresh Interval Modal dropdown (#12406) * fix(native-filters): incorrect queriesData state (#12409) * refactor: from superset.utils.core break down date_parser (#12408) * Fixes control panel fields styling (#12236) (#12326) * feat: Resizable dataset and controls panels on Explore view (#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (#12426) * chore: bump superset-ui deckgl plugin (#12466) * fix: do not show vertical scrollbar for charts in dashboard (#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * fix(dashboard): use datasource id from slice metadata (#12483) * fix(timepicker): make pyparsing thread safe (#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (#12530) * fix(explore): time table control panel (#12532) * fix(explore): Add Time section back to FilterBox (#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536) * fix: Select options overflowing Save chart modal on Explore view (#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> * Fix list filters vertical alignment (#12497) * feat(db-engine): Add support for Apache Solr (#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556) * fix: height on grid results (#12558) * fix: case expression should not have double quotes (#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Junlin Chen <junlin@preset.io> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Xiang Fu <fx19880617@gmail.com> Co-authored-by: Ahmed Adel <github@aadel.io> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu> Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>

* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (apache#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (apache#12391) * chore: Fix typo “Rest” to “Reset” (apache#12392) * chore: upgrade eslint, babel, and prettier (apache#12393) * feat(explore): add tooltip to timepicker label (apache#12401) * chore: change Datasource to Dataset in Explore ui (apache#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback * fix: Refresh Interval Modal dropdown (apache#12406) * fix(native-filters): incorrect queriesData state (apache#12409) * refactor: from superset.utils.core break down date_parser (apache#12408) * Fixes control panel fields styling (apache#12236) (apache#12326) * feat: Resizable dataset and controls panels on Explore view (apache#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (apache#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (apache#12426) * chore: bump superset-ui deckgl plugin (apache#12466) * fix: do not show vertical scrollbar for charts in dashboard (apache#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for apache#11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * fix(dashboard): use datasource id from slice metadata (apache#12483) * fix(timepicker): make pyparsing thread safe (apache#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (apache#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (apache#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (apache#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (apache#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (apache#12530) * fix(explore): time table control panel (apache#12532) * fix(explore): Add Time section back to FilterBox (apache#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (apache#12536) * fix: Select options overflowing Save chart modal on Explore view (apache#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> * Fix list filters vertical alignment (apache#12497) * feat(db-engine): Add support for Apache Solr (apache#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (apache#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (apache#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (apache#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (apache#12556) * fix: height on grid results (apache#12558) * fix: case expression should not have double quotes (apache#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (apache#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Junlin Chen <junlin@preset.io> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Xiang Fu <fx19880617@gmail.com> Co-authored-by: Ahmed Adel <github@aadel.io> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu> Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>

fix(explore): time table control panel

4062fc3

pull-request-size Bot added the size/S label Jan 15, 2021

ktmud added v1.0 viz:charts:timetable Related to the Time Table chart labels Jan 15, 2021

junlincc added the hold:testing! On hold for testing label Jan 15, 2021

zhaoyongjie self-requested a review January 15, 2021 02:35

zhaoyongjie approved these changes Jan 15, 2021

View reviewed changes

ktmud mentioned this pull request Jan 15, 2021

[code hygiene] Fully move Timeseries Table plugin to superset-ui #12533

Closed

junlincc removed the hold:testing! On hold for testing label Jan 15, 2021

junlincc merged commit 41b7eb3 into apache:master Jan 15, 2021

ktmud added a commit to airbnb/superset-fork that referenced this pull request Jan 15, 2021

fix(explore): time table control panel (apache#12532)

06944ee

villebro pushed a commit that referenced this pull request Jan 15, 2021

fix(explore): time table control panel (#12532)

027e207

villebro pushed a commit to preset-io/superset that referenced this pull request Jan 15, 2021

fix(explore): time table control panel (apache#12532)

1a7c0be

villebro pushed a commit to preset-io/superset that referenced this pull request Jan 15, 2021

fix(explore): time table control panel (apache#12532)

e981a18

ktmud added the requires:tests This PR requires tests label Feb 24, 2021

mistercrunch added 🍒 1.0.0 Cherry-picked to 1.0.0 🍒 1.0.1 Cherry-picked to 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

fix(explore): time table control panel (apache#12532)

0f09a28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(explore): time table control panel#12532

fix(explore): time table control panel#12532
junlincc merged 1 commit into
apache:masterfrom
ktmud:fix-time-table2

ktmud commented Jan 15, 2021 •

edited

Loading

Uh oh!

zhaoyongjie left a comment

Uh oh!

codecov-io commented Jan 15, 2021 •

edited

Loading

Uh oh!

junlincc commented Jan 15, 2021 •

edited

Loading

Uh oh!

ktmud commented Jan 15, 2021

Uh oh!

junlincc commented Jan 15, 2021 •

edited

Loading

Uh oh!

ktmud commented Jan 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ktmud commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

zhaoyongjie left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

junlincc commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktmud commented Jan 15, 2021

Uh oh!

junlincc commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktmud commented Jan 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ktmud commented Jan 15, 2021 •

edited

Loading

codecov-io commented Jan 15, 2021 •

edited

Loading

junlincc commented Jan 15, 2021 •

edited

Loading

junlincc commented Jan 15, 2021 •

edited

Loading