fix(dashboard): uncaught error when loading dashboards with slices associated with deleted dataset by bechob · Pull Request #12535 · apache/superset

bechob · 2021-01-15T03:51:38Z

SUMMARY

Fix uncaught error when loading dashboards with slices associated with deleted dataset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TEST PLAN

Run superset locally
Delete the dataset of a chart that belongs to a dashboard
Open the dashboard which includes the chart

ADDITIONAL INFORMATION

codecov-io · 2021-01-15T04:35:28Z

Codecov Report

Merging #12535 (3e7b8d1) into master (8adc8b8) will decrease coverage by 4.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12535      +/-   ##
==========================================
- Coverage   63.79%   59.24%   -4.56%     
==========================================
  Files         932      959      +27     
  Lines       45213    46861    +1648     
  Branches     4335     4353      +18     
==========================================
- Hits        28843    27762    -1081     
- Misses      16193    19099    +2906     
+ Partials      177        0     -177

Flag	Coverage Δ
cypress	`50.99% <ø> (?)`
javascript	`?`
python	`63.89% <ø> (-0.28%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/models/dashboard.py	`75.50% <ø> (ø)`
...uperset-frontend/src/dashboard/util/dnd-reorder.js	`0.00% <0.00%> (-100.00%)`	⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js	`0.00% <0.00%> (-100.00%)`	⬇️
...dashboard/components/resizable/ResizableHandle.jsx	`0.00% <0.00%> (-100.00%)`	⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js	`0.00% <0.00%> (-93.48%)`	⬇️
...src/dashboard/components/gridComponents/Header.jsx	`10.52% <0.00%> (-86.85%)`	⬇️
...rc/dashboard/components/gridComponents/Divider.jsx	`13.33% <0.00%> (-86.67%)`	⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx	`14.70% <0.00%> (-82.97%)`	⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx	`5.71% <0.00%> (-82.10%)`	⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx	`11.11% <0.00%> (-81.20%)`	⬇️
... and 587 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adc8b8...3e7b8d1. Read the comment docs.

junlincc · 2021-01-15T05:47:55Z

related #12476
@adam-stasiak please take a look 🙏

Many thanks for the PR!

adam-stasiak · 2021-01-15T11:18:22Z

Works for dashboards fine! Nothing crashes. When dashboard is open user is notified about the reason why chart is not available. looks good.

bkyryliuk · 2021-01-15T19:33:26Z

@bechob please rerun black, looks like CI is failing

…et (#12535)

* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (#12391) * chore: Fix typo “Rest” to “Reset” (#12392) * chore: upgrade eslint, babel, and prettier (#12393) * feat(explore): add tooltip to timepicker label (#12401) * chore: change Datasource to Dataset in Explore ui (#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback * fix: Refresh Interval Modal dropdown (#12406) * fix(native-filters): incorrect queriesData state (#12409) * refactor: from superset.utils.core break down date_parser (#12408) * Fixes control panel fields styling (#12236) (#12326) * feat: Resizable dataset and controls panels on Explore view (#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (#12426) * chore: bump superset-ui deckgl plugin (#12466) * fix: do not show vertical scrollbar for charts in dashboard (#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * fix(dashboard): use datasource id from slice metadata (#12483) * fix(timepicker): make pyparsing thread safe (#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (#12530) * fix(explore): time table control panel (#12532) * fix(explore): Add Time section back to FilterBox (#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536) * fix: Select options overflowing Save chart modal on Explore view (#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> * Fix list filters vertical alignment (#12497) * feat(db-engine): Add support for Apache Solr (#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556) * fix: height on grid results (#12558) * fix: case expression should not have double quotes (#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Junlin Chen <junlin@preset.io> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Xiang Fu <fx19880617@gmail.com> Co-authored-by: Ahmed Adel <github@aadel.io> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu> Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>

…et (apache#12535)

* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (apache#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (apache#12391) * chore: Fix typo “Rest” to “Reset” (apache#12392) * chore: upgrade eslint, babel, and prettier (apache#12393) * feat(explore): add tooltip to timepicker label (apache#12401) * chore: change Datasource to Dataset in Explore ui (apache#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback * fix: Refresh Interval Modal dropdown (apache#12406) * fix(native-filters): incorrect queriesData state (apache#12409) * refactor: from superset.utils.core break down date_parser (apache#12408) * Fixes control panel fields styling (apache#12236) (apache#12326) * feat: Resizable dataset and controls panels on Explore view (apache#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (apache#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (apache#12426) * chore: bump superset-ui deckgl plugin (apache#12466) * fix: do not show vertical scrollbar for charts in dashboard (apache#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for apache#11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * fix(dashboard): use datasource id from slice metadata (apache#12483) * fix(timepicker): make pyparsing thread safe (apache#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (apache#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (apache#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (apache#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (apache#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (apache#12530) * fix(explore): time table control panel (apache#12532) * fix(explore): Add Time section back to FilterBox (apache#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (apache#12536) * fix: Select options overflowing Save chart modal on Explore view (apache#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> * Fix list filters vertical alignment (apache#12497) * feat(db-engine): Add support for Apache Solr (apache#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (apache#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (apache#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (apache#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (apache#12556) * fix: height on grid results (apache#12558) * fix: case expression should not have double quotes (apache#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (apache#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Junlin Chen <junlin@preset.io> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Xiang Fu <fx19880617@gmail.com> Co-authored-by: Ahmed Adel <github@aadel.io> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu> Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>

pull-request-size Bot added the size/XS label Jan 15, 2021

bechob changed the title ~~Fix uncaught error when loading dashboards with slices associated with deleted dataset~~ (fix): uncaught error when loading dashboards with slices associated with deleted dataset Jan 15, 2021

junlincc changed the title ~~(fix): uncaught error when loading dashboards with slices associated with deleted dataset~~ fix(dashboard): uncaught error when loading dashboards with slices associated with deleted dataset Jan 15, 2021

bkyryliuk self-requested a review January 15, 2021 19:32

bkyryliuk approved these changes Jan 15, 2021

View reviewed changes

Comment thread superset/models/dashboard.py Outdated

Copy link
Copy Markdown

Member

bkyryliuk Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bechob please rerun black, looks like CI is failing

bkyryliuk requested a review from ktmud January 15, 2021 19:33

bechob force-pushed the fix/500-dashboard branch from 9d7098a to cc28179 Compare January 15, 2021 19:52

Fix 500 error when loading dashboards with slice having deleted dataset

3e7b8d1

bechob force-pushed the fix/500-dashboard branch from cc28179 to 3e7b8d1 Compare January 15, 2021 19:58

bkyryliuk added the v1.0 label Jan 15, 2021

bkyryliuk merged commit b50fd3e into apache:master Jan 15, 2021

villebro pushed a commit that referenced this pull request Jan 16, 2021

Fix 500 error when loading dashboards with slice having deleted datas…

2187d1a

…et (#12535)

mistercrunch added 🍒 1.0.0 Cherry-picked to 1.0.0 🍒 1.0.1 Cherry-picked to 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

Fix 500 error when loading dashboards with slice having deleted datas…

d49805d

…et (apache#12535)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dashboard): uncaught error when loading dashboards with slices associated with deleted dataset#12535

fix(dashboard): uncaught error when loading dashboards with slices associated with deleted dataset#12535
bkyryliuk merged 1 commit into
apache:masterfrom
bechob:fix/500-dashboard

bechob commented Jan 15, 2021

Uh oh!

codecov-io commented Jan 15, 2021 •

edited

Loading

Uh oh!

junlincc commented Jan 15, 2021

Uh oh!

adam-stasiak commented Jan 15, 2021

Uh oh!

bkyryliuk Jan 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

bechob commented Jan 15, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

codecov-io commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

junlincc commented Jan 15, 2021

Uh oh!

adam-stasiak commented Jan 15, 2021

Uh oh!

bkyryliuk Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov-io commented Jan 15, 2021 •

edited

Loading