feat: first step native support Trino

[dungdm93]

SUMMARY

Previously, SuperSet was able to access Presto through the PyHive, even though it's not the official python driver, as well as it is not in active development. However, since Dec 27, 2020, PrestoSQL was renamed to Trino, this mean you can't using PyHive to access Trino any more.
So this MR is first step native support Trino using official python driver

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Unit test already added

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #13105 (967a6e3) into master (2ce7982) will increase coverage by 9.05%.
The diff coverage is 36.21%.

@@            Coverage Diff             @@
##           master   #13105      +/-   ##
==========================================
+ Coverage   53.06%   62.11%   +9.05%     
==========================================
  Files         489      982     +493     
  Lines       17314    46314   +29000     
  Branches     4482     4505      +23     
==========================================
+ Hits         9187    28769   +19582     
- Misses       8127    17545    +9418     

Flag	Coverage Δ
cypress	53.37% <50.00%> (+0.31%)	⬆️
python	67.35% <31.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx	52.77% <ø> (ø)
superset-frontend/src/chart/ChartContainer.jsx	100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx	75.67% <0.00%> (-1.04%)	⬇️
...perset-frontend/src/common/components/Dropdown.tsx	50.00% <ø> (ø)
...rontend/src/components/ListView/CardSortSelect.tsx	78.94% <ø> (ø)
...ontend/src/components/ListViewCard/ImageLoader.tsx	75.00% <0.00%> (ø)
...set-frontend/src/components/URLShortLinkButton.jsx	100.00% <ø> (ø)
...rset-frontend/src/components/URLShortLinkModal.tsx	77.77% <ø> (ø)
...src/dashboard/components/HeaderActionsDropdown.jsx	68.49% <ø> (+0.92%)	⬆️
...end/src/dashboard/components/StickyVerticalBar.tsx	100.00% <ø> (ø)
... and 545 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acca3a4...967a6e3. Read the comment docs.

[villebro]

Thanks so much for this! The Presto spec has been in need of some TLC for a while now, so this is a perfect opportunity to make sure the Trino connector is well supported and has good test coverage!

[betodealmeida]

@dungdm93 PyHive nows supports Trino. Do you think it would be better to use PyHIve, given that it's SQLAlchemy dialect is more mature, or do you think we should use the SQLAlchemy dialect you created, since it uses the official trino Python driver?

[dungdm93]

Hi @betodealmeida, greet question.
PyHive code is messy, that is why I create separate package. And for your info, I also working on porting this dialect to upstream trino python client trinodb/trino-python-client#81

[findepi]

Yes, pyhive is definitely more mature now, but I'd still recommend the official Trino driver which we (the Trino community) maintain.
as @dungdm93 pointed out, the SQLAlchemy support is going to be integral part of that package.

[olivier-inion]

Hi, i try to use trino with superset and i got this error :'trino error: 'Cursor' object has no attribute 'poll'
( trino works well with cli or jdbc driver ).
in sqllab , i only see 'jdbc','information_schema','metadate','runtime' schemas (and none of my 4 catalogs )

it's a fresh install with docker-compose, i try to add sqlachemy-trino in 'requirements-local.txt' but logs says that this dependency is already here ( i can see it in the setup.py ).

i don't understand that i'm missing to do.

[olivier-inion]

ok; it's working with v1.5.0 superset

[mingfang]

I'm still getting the 'Cursor' object has no attribute 'poll' error in the latest docker image

[olivier-inion]

use this method to install
after cloning repo, go to superset directory and do :

git checkout 1.5.0
TAG=1.5.0 docker-compose -f docker-compose-non-dev.yml pull
TAG=1.5.0 docker-compose -f docker-compose-non-dev.yml up