Skip to content

docs: Connecting to Trino Databases#13171

Merged
srinify merged 3 commits into
apache:masterfrom
dungdm93:trino-docs
Feb 23, 2021
Merged

docs: Connecting to Trino Databases#13171
srinify merged 3 commits into
apache:masterfrom
dungdm93:trino-docs

Conversation

@dungdm93
Copy link
Copy Markdown
Contributor

@dungdm93 dungdm93 commented Feb 17, 2021

SUMMARY

Following #13105, this MR add Connecting to Trino Databases user-guide doc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 18, 2021

Codecov Report

Merging #13171 (5bce3de) into master (2ce7982) will increase coverage by 20.04%.
The diff coverage is 63.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13171       +/-   ##
===========================================
+ Coverage   53.06%   73.10%   +20.04%     
===========================================
  Files         489      552       +63     
  Lines       17314    20421     +3107     
  Branches     4482     5277      +795     
===========================================
+ Hits         9187    14928     +5741     
+ Misses       8127     5365     -2762     
- Partials        0      128      +128     
Flag Coverage Δ
cypress 58.43% <69.90%> (+5.37%) ⬆️
javascript 62.34% <47.39%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (+11.50%) ⬆️
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 77.02% <0.00%> (+0.31%) ⬆️
...perset-frontend/src/common/components/Dropdown.tsx 54.76% <ø> (+4.76%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 60.00% <0.00%> (+2.85%) ⬆️
...t-frontend/src/components/DynamicPlugins/index.tsx 27.65% <ø> (+4.40%) ⬆️
...ontend/src/components/ListViewCard/ImageLoader.tsx 86.36% <0.00%> (+11.36%) ⬆️
superset-frontend/src/components/Menu/SubMenu.tsx 100.00% <ø> (+6.45%) ⬆️
...set-frontend/src/components/URLShortLinkButton.jsx 100.00% <ø> (ø)
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <ø> (+2.12%) ⬆️
... and 505 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48b894...5bce3de. Read the comment docs.

@villebro villebro requested a review from srinify February 18, 2021 06:06
@srinify
Copy link
Copy Markdown
Contributor

srinify commented Feb 19, 2021

Thanks @dungdm93 for adding this! I'll review this weekend!

@dungdm93
Copy link
Copy Markdown
Contributor Author

@srinify Could you please review my PR

@srinify
Copy link
Copy Markdown
Contributor

srinify commented Feb 23, 2021

Thanks @dungdm93 for this great addition!

@srinify srinify merged commit e8114be into apache:master Feb 23, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* feat: add trino logo

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores: update image links in README.md

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* docs: add Trino Connecting to Databases doc

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants