feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters#14313
Merged
Merged
Conversation
kgabryje
changed the title
8 tasks
kgabryje
force-pushed
the
feat/native-filters-adhoc
branch
from
664913b to
e3b2cc6
Compare
kgabryje
force-pushed
the
feat/native-filters-adhoc
branch
from
7e38f2b to
b2b371c
Compare
Codecov Report
@@ Coverage Diff @@
## master #14313 +/- ##
==========================================
- Coverage 77.18% 77.17% -0.01%
==========================================
Files 954 954
Lines 48134 48171 +37
Branches 5985 5998 +13
==========================================
+ Hits 37151 37177 +26
- Misses 10786 10797 +11
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
changed the title
junlincc
added
the
dashboard:native-filters
amitmiran137
pushed a commit
that referenced
this pull request
Apr 28, 2021
…e and Select native filters (#14313) * Implement adhoc filters in Range and Select native filters * Add time picker * Remove additional filters from datamask * Create separate stylesheet for AdhocFilterControl in native filters * Rename Time picker to Time range * Fix columns in AdhocFilter empty when creating a new filter * Skip flaky test (cherry picked from commit 20ab086)
11 tasks
8 tasks
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…e and Select native filters (apache#14313) * Implement adhoc filters in Range and Select native filters * Add time picker * Remove additional filters from datamask * Create separate stylesheet for AdhocFilterControl in native filters * Rename Time picker to Time range * Fix columns in AdhocFilter empty when creating a new filter * Skip flaky test
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…e and Select native filters (apache#14313) * Implement adhoc filters in Range and Select native filters * Add time picker * Remove additional filters from datamask * Create separate stylesheet for AdhocFilterControl in native filters * Rename Time picker to Time range * Fix columns in AdhocFilter empty when creating a new filter * Skip flaky test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an Adhoc Filters and Time Picker controls to native filters modal - works with Range and Select filters.
Setting an adhoc filter or a time picker affects what values (or a range of values) can be chosen from a filter.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-04-26.at.14.45.03.mov
TEST PLAN
ADDITIONAL INFORMATION
@junlincc @villebro @ktmud