feat(native-filters): add optional sort metric to select filter#14346
Merged
villebro merged 10 commits intoApr 27, 2021
Conversation
kgabryje
reviewed
Apr 26, 2021
| const datasetId = formFilter?.dataset?.value; | ||
|
|
||
| useEffect(() => { | ||
| if (datasetId) { |
Member
There was a problem hiding this comment.
If #14313 is merged first, that won't be necessary - metrics can be accessed in formFilter.dataset?.metrics
Member
Author
There was a problem hiding this comment.
Oh nice, let's get that one in first then 👍
Member
|
This PR looks well! tested in local environment.
|
zhaoyongjie
reviewed
Apr 26, 2021
| name="sortMetric" | ||
| options={metrics.map((metric: Metric) => ({ | ||
| value: metric.metric_name, | ||
| label: metric.metric_name, |
Member
There was a problem hiding this comment.
one nit:
Suggested change
| label: metric.metric_name, | |
| label: metric.verbose_name ?? metric.metric_name, |
Member
Author
There was a problem hiding this comment.
Thanks @zhaoyongjie ; thanks for catching this!
zhaoyongjie
approved these changes
Apr 26, 2021
junlincc
added
the
dashboard:native-filters
Codecov Report
@@ Coverage Diff @@
## master #14346 +/- ##
==========================================
- Coverage 76.86% 76.71% -0.16%
==========================================
Files 954 954
Lines 48207 48230 +23
Branches 6008 6021 +13
==========================================
- Hits 37056 37001 -55
- Misses 10956 11034 +78
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
pushed a commit
that referenced
this pull request
Apr 28, 2021
* feat(native-filters): add optional sort metric to select filter * use verbose name when defined * fixes * lint * disable flaky test * disable flaky test * disable flaky test (cherry picked from commit 40fb94d)
11 tasks
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…he#14346) * feat(native-filters): add optional sort metric to select filter * use verbose name when defined * fixes * lint * disable flaky test * disable flaky test * disable flaky test
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…he#14346) * feat(native-filters): add optional sort metric to select filter * use verbose name when defined * fixes * lint * disable flaky test * disable flaky test * disable flaky test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for sort metric to native select filter. This is a requirement to establish feature parity with Filter Box.
SCREENSHOTS
An optional field appears on the filter config modal for the select filter:
When selected, the column values are sorted by the selected metric (in this case in descending order)
TEST PLAN
Local testing + CI
ADDITIONAL INFORMATION