Skip to content

test: Functional RTL for email report modal II#16148

Merged
eschutho merged 12 commits into
apache:masterfrom
preset-io:lyndsi/email-report-rtl2
Aug 20, 2021
Merged

test: Functional RTL for email report modal II#16148
eschutho merged 12 commits into
apache:masterfrom
preset-io:lyndsi/email-report-rtl2

Conversation

@lyndsiWilliams
Copy link
Copy Markdown
Member

@lyndsiWilliams lyndsiWilliams commented Aug 9, 2021

SUMMARY

Implements functional RTL testing for the email report modal

TESTING INSTRUCTIONS

  • Report Modal
    • Navigate to the following location in your terminal: src/components/ReportModal/
    • Use the following command to observe the test suite: npm run test -t index.test.tsx
  • Dashboard implementation
    • Navigate to the following location in your terminal: superset-frontend/src/dashboard/components/Header
    • Use the following command to observe the test suite: npm run test -t Header.test.tsx

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review August 16, 2021 16:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2021

Codecov Report

Merging #16148 (d6ec221) into master (3709131) will decrease coverage by 0.28%.
The diff coverage is 59.72%.

❗ Current head d6ec221 differs from pull request most recent head 1607fc6. Consider uploading reports for the commit 1607fc6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16148      +/-   ##
==========================================
- Coverage   76.70%   76.42%   -0.29%     
==========================================
  Files         997     1000       +3     
  Lines       53240    53479     +239     
  Branches     6774     6815      +41     
==========================================
+ Hits        40838    40870      +32     
- Misses      12172    12373     +201     
- Partials      230      236       +6     
Flag Coverage Δ
hive ?
javascript 70.88% <54.01%> (-0.08%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx 0.00% <0.00%> (ø)
...set-frontend/src/explore/actions/exploreActions.ts 36.20% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 15.00% <0.00%> (ø)
...controls/DndColumnSelectControl/DndSelectLabel.tsx 77.27% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 57.69% <ø> (ø)
.../FilterControl/AdhocFilterPopoverTrigger/index.tsx 80.76% <ø> (ø)
...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx 72.30% <ø> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx 42.05% <ø> (ø)
superset-frontend/src/views/App.tsx 0.00% <ø> (ø)
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3709131...1607fc6. Read the comment docs.

@eschutho eschutho merged commit 518c3c9 into apache:master Aug 20, 2021
@eschutho eschutho deleted the lyndsi/email-report-rtl2 branch August 20, 2021 17:08
MaxHuiYYDS pushed a commit to MaxHuiYYDS/superset that referenced this pull request Aug 22, 2021
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 24, 2021
* master: (582 commits)
  feat: config to customize bootstrap data overrides (apache#16386)
  fix: regex for multi-region IPs (apache#16410)
  chore: Changes the DatabaseSelector to use the new Select component (apache#16334)
  chore: Displays the dataset description in a tooltip in the datasets list (apache#16392)
  fix(pylint): Fix master (apache#16405)
  chore(pylint): Enable useless-suppression check (apache#16388)
  feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361)
  initial commit (apache#16366)
  fix: big number default date format (apache#16383)
  initial commit (apache#16380)
  fix: import dashboard w/o metadata (apache#16360)
  test: Functional RTL for email report modal II (apache#16148)
  fix: update table ID in query context on chart import (apache#16374)
  docs: document FLASK_APP_MUTATOR (apache#16286)
  feat: Add new dev commands to Makefile (apache#16327)
  fix: call external metadata endpoint with correct rison object (apache#16369)
  fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330)
  fix: columns/index rebuild (apache#16355)
  chore(viz): bump deckgl plugin to 0.4.11 (apache#16353)
  fix: Blank space in Change dataset modal without warning message (apache#16324)
  ...

# Conflicts:
#	superset/app.py
#	superset/models/dashboard.py
#	tests/integration_tests/charts/filter_sets/__init__.py
#	tests/integration_tests/charts/filter_sets/conftest.py
#	tests/integration_tests/charts/filter_sets/consts.py
#	tests/integration_tests/charts/filter_sets/create_api_tests.py
#	tests/integration_tests/charts/filter_sets/delete_api_tests.py
#	tests/integration_tests/charts/filter_sets/get_api_tests.py
#	tests/integration_tests/charts/filter_sets/update_api_tests.py
#	tests/integration_tests/charts/filter_sets/utils.py
#	tests/integration_tests/superset_test_config.py
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants