Skip to content

fix: import dashboard w/o metadata#16360

Merged
betodealmeida merged 1 commit into
apache:masterfrom
betodealmeida:fix_import_dash_wo_metadata
Aug 20, 2021
Merged

fix: import dashboard w/o metadata#16360
betodealmeida merged 1 commit into
apache:masterfrom
betodealmeida:fix_import_dash_wo_metadata

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

SUMMARY

Some exported dashboards don't have metadata, and importing them is failing.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: can't import dash.
After: can import correctly.

TESTING INSTRUCTIONS

Try to import this dashboard: dashboard_export_20210819T112813.zip

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2021

Codecov Report

Merging #16360 (f337a2e) into master (50d896f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16360   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files        1000     1000           
  Lines       53479    53479           
  Branches     6815     6815           
=======================================
  Hits        40840    40840           
  Misses      12403    12403           
  Partials      236      236           
Flag Coverage Δ
mysql 81.48% <100.00%> (ø)
postgres 81.54% <100.00%> (ø)
python 81.63% <100.00%> (ø)
sqlite 81.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset/dashboards/commands/importers/v1/__init__.py 98.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d896f...f337a2e. Read the comment docs.

@junlincc
Copy link
Copy Markdown
Member

🙏 thanks for the quick fix!

@betodealmeida betodealmeida merged commit 649e509 into apache:master Aug 20, 2021
MaxHuiYYDS pushed a commit to MaxHuiYYDS/superset that referenced this pull request Aug 22, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 24, 2021
* master: (582 commits)
  feat: config to customize bootstrap data overrides (apache#16386)
  fix: regex for multi-region IPs (apache#16410)
  chore: Changes the DatabaseSelector to use the new Select component (apache#16334)
  chore: Displays the dataset description in a tooltip in the datasets list (apache#16392)
  fix(pylint): Fix master (apache#16405)
  chore(pylint): Enable useless-suppression check (apache#16388)
  feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361)
  initial commit (apache#16366)
  fix: big number default date format (apache#16383)
  initial commit (apache#16380)
  fix: import dashboard w/o metadata (apache#16360)
  test: Functional RTL for email report modal II (apache#16148)
  fix: update table ID in query context on chart import (apache#16374)
  docs: document FLASK_APP_MUTATOR (apache#16286)
  feat: Add new dev commands to Makefile (apache#16327)
  fix: call external metadata endpoint with correct rison object (apache#16369)
  fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330)
  fix: columns/index rebuild (apache#16355)
  chore(viz): bump deckgl plugin to 0.4.11 (apache#16353)
  fix: Blank space in Change dataset modal without warning message (apache#16324)
  ...

# Conflicts:
#	superset/app.py
#	superset/models/dashboard.py
#	tests/integration_tests/charts/filter_sets/__init__.py
#	tests/integration_tests/charts/filter_sets/conftest.py
#	tests/integration_tests/charts/filter_sets/consts.py
#	tests/integration_tests/charts/filter_sets/create_api_tests.py
#	tests/integration_tests/charts/filter_sets/delete_api_tests.py
#	tests/integration_tests/charts/filter_sets/get_api_tests.py
#	tests/integration_tests/charts/filter_sets/update_api_tests.py
#	tests/integration_tests/charts/filter_sets/utils.py
#	tests/integration_tests/superset_test_config.py
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/XS 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants