Skip to content

fix: adjust initial state of report modal#16329

Merged
eschutho merged 1 commit into
apache:masterfrom
preset-io:elizabeth/fix-blank-png-report
Aug 18, 2021
Merged

fix: adjust initial state of report modal#16329
eschutho merged 1 commit into
apache:masterfrom
preset-io:elizabeth/fix-blank-png-report

Conversation

@eschutho
Copy link
Copy Markdown
Member

SUMMARY

This fixes a bug where the initial state and state reset wasn't passing through the correct report format

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

Create a chart without changing anything, and it should pass in the correct initial state.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Copy link
Copy Markdown
Member Author

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

@eschutho Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

@eschutho Ephemeral environment creation failed. Please check the Actions logs for details.

@eschutho
Copy link
Copy Markdown
Member Author

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

@eschutho Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

@eschutho Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2021

Codecov Report

Merging #16329 (2d910d3) into master (a547dcb) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16329      +/-   ##
==========================================
- Coverage   76.54%   76.53%   -0.01%     
==========================================
  Files        1000     1000              
  Lines       53424    53422       -2     
  Branches     6818     6816       -2     
==========================================
- Hits        40891    40889       -2     
  Misses      12297    12297              
  Partials      236      236              
Flag Coverage Δ
javascript 70.76% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ReportModal/index.tsx 72.91% <50.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a547dcb...2d910d3. Read the comment docs.

@eschutho
Copy link
Copy Markdown
Member Author

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

@eschutho Ephemeral environment spinning up at http://34.212.35.245:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Copy Markdown
Member

yousoph commented Aug 18, 2021

/testenv up FEATURE_ALERTS_REPORTS=true

@github-actions
Copy link
Copy Markdown
Contributor

@yousoph Ephemeral environment spinning up at http://54.191.135.65:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Copy Markdown
Member

yousoph commented Aug 18, 2021

/testenv up FEATURE_ALERT_REPORTS=true

@github-actions
Copy link
Copy Markdown
Contributor

@yousoph Ephemeral environment spinning up at http://54.213.249.207:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho merged commit efe850b into apache:master Aug 18, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Ephemeral environment shutdown and build artifacts deleted.

betodealmeida pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
(cherry picked from commit efe850b)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 preset-io size/S 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants