Skip to content

fix(explore): JS error for creating new metrics from columns#16477

Merged
ktmud merged 1 commit into
apache:masterfrom
airbnb:dnd-fix-js-error
Aug 27, 2021
Merged

fix(explore): JS error for creating new metrics from columns#16477
ktmud merged 1 commit into
apache:masterfrom
airbnb:dnd-fix-js-error

Conversation

@ktmud
Copy link
Copy Markdown
Member

@ktmud ktmud commented Aug 26, 2021 •
edited
Loading

SUMMARY

This closes #16471 , but was introduced by #16362 .

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Test manually locally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2021

Codecov Report

Merging #16477 (d121296) into master (ee2eccd) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16477   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files        1002     1002           
  Lines       53672    53670    -2     
  Branches     6853     6852    -1     
=======================================
  Hits        41006    41006           
+ Misses      12427    12425    -2     
  Partials      239      239
Flag Coverage Δ
javascript 70.83% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 41.40% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2eccd...d121296. Read the comment docs.

@ktmud
Copy link
Copy Markdown
Member Author

ktmud commented Aug 26, 2021

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2021

@ktmud Ephemeral environment spinning up at http://52.11.145.140:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@ktmud
Copy link
Copy Markdown
Member Author

ktmud commented Aug 26, 2021 •
edited
Loading

Okay... testenv is useless since it doesn't have the feature flags enabled.

@robdiciuccio how difficult do you think if we are to make slash command accept feature flags?

@nytai
Copy link
Copy Markdown
Member

nytai commented Aug 26, 2021

@ktmud yes, example #16329 (comment)

@ktmud
Copy link
Copy Markdown
Member Author

ktmud commented Aug 26, 2021

@nytai This is awesome. Thank you!

@ktmud
Copy link
Copy Markdown
Member Author

ktmud commented Aug 26, 2021

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_ENABLE_DND_WITH_CLICK_UX=true

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2021

@ktmud Ephemeral environment spinning up at http://18.236.158.181:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@ktmud ktmud merged commit a413f79 into apache:master Aug 27, 2021
@ktmud ktmud deleted the dnd-fix-js-error branch August 27, 2021 00:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2021

Ephemeral environment shutdown and build artifacts deleted.

@ktmud
Copy link
Copy Markdown
Member Author

ktmud commented Aug 27, 2021

Verified with testenv, merging

amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 29, 2021
Merge remote-tracking branch 'upstream/master' into feat/fileter_set
ee7c4e5 
* upstream/master:
  fix: create example DB if needed (apache#16451)
  fix(native-filters): add handle undefined control value gracefully (apache#16468)
  Revert "chore: Changes the DatabaseSelector to use the new Select component (apache#16334)" (apache#16478)
  fix(explore): JS error for creating new metrics from columns (apache#16477)
  fix: queryEditor bug (apache#16452)
  docs: make code snippet usable with required imports (apache#16473)
  perf(dashboard): decouple redux props from dashboard components (apache#16421)
  perf(dashboard): reduce number of rerenders of Charts (apache#16444)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@ktmud
fix(explore): JS error for creating new metrics from columns (apache#…
6df5485 
…16477)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@ktmud
fix(explore): JS error for creating new metrics from columns (apache#…
acc903c 
…16477)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@ktmud
fix(explore): JS error for creating new metrics from columns (apache#…
b85afbb 
…16477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michellethomas michellethomas michellethomas approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels request:qa-review Requests a QA review size/XS test_priority:high 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[dragndrop]unexpected error in metric - pivot table

5 participants

@ktmud @nytai @michellethomas @mistercrunch @junlincc