Skip to content

docs: Make code snippet usable with required imports in configuration doc#16473

Merged
nytai merged 1 commit into
apache:masterfrom
shawnzhu:doc-flask-app-mutator
Aug 26, 2021
Merged

docs: Make code snippet usable with required imports in configuration doc#16473
nytai merged 1 commit into
apache:masterfrom
shawnzhu:doc-flask-app-mutator

Conversation

@shawnzhu
Copy link
Copy Markdown
Contributor

SUMMARY

This is a problem surfaced from this thread in Slack

I try to config like https://superset.apache.org/docs/installation/configuring-superset#flask-app-configuration-hook but it fail with "session" not found

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

When manually copying the code stanza under section Flask app Configuration Hook, it should not fail application starting.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai merged commit fd64561 into apache:master Aug 26, 2021
@shawnzhu shawnzhu deleted the doc-flask-app-mutator branch August 27, 2021 00:14
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 29, 2021
* upstream/master:
  fix: create example DB if needed (apache#16451)
  fix(native-filters): add handle undefined control value gracefully (apache#16468)
  Revert "chore: Changes the DatabaseSelector to use the new Select component (apache#16334)" (apache#16478)
  fix(explore): JS error for creating new metrics from columns (apache#16477)
  fix: queryEditor bug (apache#16452)
  docs: make code snippet usable with required imports (apache#16473)
  perf(dashboard): decouple redux props from dashboard components (apache#16421)
  perf(dashboard): reduce number of rerenders of Charts (apache#16444)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants