Skip to content

docs: make FEATURE_FLAGS.md reference a link#16415

Merged
suddjian merged 1 commit into
masterfrom
docs/link-ff
Aug 24, 2021
Merged

docs: make FEATURE_FLAGS.md reference a link#16415
suddjian merged 1 commit into
masterfrom
docs/link-ff

Conversation

@suddjian
Copy link
Copy Markdown
Member

@suddjian suddjian commented Aug 24, 2021

SUMMARY

It should be a link

TESTING INSTRUCTIONS

look at the feature flags page in the docs site, click link to FEATURE_FLAGS.md

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 24, 2021

Codecov Report

Merging #16415 (e26ac2f) into master (486ef6b) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16415      +/-   ##
==========================================
- Coverage   76.55%   76.48%   -0.08%     
==========================================
  Files        1000     1000              
  Lines       53487    53487              
  Branches     6818     6818              
==========================================
- Hits        40948    40907      -41     
- Misses      12301    12342      +41     
  Partials      238      238              
Flag Coverage Δ
hive 81.22% <ø> (ø)
javascript 70.69% <ø> (ø)
mysql 81.53% <ø> (ø)
postgres 81.55% <ø> (ø)
presto ?
python 81.92% <ø> (-0.15%) ⬇️
sqlite 81.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 84.51% <0.00%> (-5.86%) ⬇️
superset/connectors/sqla/models.py 88.28% <0.00%> (-1.43%) ⬇️
superset/models/core.py 89.14% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486ef6b...e26ac2f. Read the comment docs.

@suddjian suddjian merged commit e71c6e6 into master Aug 24, 2021
@suddjian suddjian deleted the docs/link-ff branch August 24, 2021 21:08
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 26, 2021
* upstream/master: (25 commits)
  chore(ci): bump pylint to 2.10.2 (apache#16463)
  fix: prevent page crash when chart can't render (apache#16464)
  chore: fixed slack invite link (apache#16466)
  fix(native-filters): handle null values in value filter (apache#16460)
  feat: add function list to auto-complete to Clickhouse datasource (apache#16234)
  refactor(explore): improve typing for Dnd controls (apache#16362)
  fix(explore): update overwrite button on perm change (apache#16437)
  feat: Draggable and Resizable Modal (apache#16394)
  refactor: sql_json view endpoint (apache#16441)
  fix(dashboard): undo and redo buttons weird alignment  (apache#16417)
  fix: setupPlugin in chart list page (apache#16413)
  fix: Disable Slack notification method if no api token (apache#16367)
  feat: add Shillelagh DB engine spec (apache#16416)
  fix: copy to Clipboard order (apache#16299)
  docs: make FEATURE_FLAGS.md reference a link (apache#16415)
  chore(viz): bump superset-ui to 0.17.87 (apache#16420)
  feat: add activate command (apache#16404)
  Revert "fix(explore): let admin overwrite slice (apache#16290)" (apache#16408)
  fix(explore): retain chart ownership on query context update (apache#16419)
  chore: Removes the TODOs and uses the default page size (apache#16422)
  ...
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants