fix(explore): update overwrite button on perm change

[villebro]

SUMMARY

Currently the Explore view does not update the "can_overwrite" permission when the user updates the chart ownership, as it's populated from bootstrap data (rendered server-side when page is loaded). In addition, the "Save" button in the chart metadata modal is enabled when the owners array is initially empty, but after adding and removing a user the save button gets disabled.

This removes the can_overwrite property from the Explore bootstrap data and replaces it with state from Redux, making it possible to change the disabled state of the "Save (Overwrite)" button in the Save modal. In addition, the slice.owners property in bootstrap data is changed to provide numeric ids instead of "firstname lastname" (most other models were already returning owners in this format; it appears the "firstname lastname" results weren't being used anywhere in Explore). Also update some types and remove redundant user_id property from bootstrap data.

AFTER

explore-after.mp4

BEFORE

explore-before.mp4

TESTING INSTRUCTIONS

1. Login as Admin
2. Open the Charts page and edit the metadata of an example dataset that doesn't have any owners
3. Add and remove yourself as owner and notice how the Save button goes from being enabled to disabled without the owners changing. Click cancel.
4. Open an example chart in Explore that doesn't have any owners
5. Add yourself as an owner
6. Try to overwrite the chart - notice that the "Save (Overwrite)" radio button is disabled

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

This had to be explicitly added, as the action is missing the owners prop when all owners are missing

[codecov]

Codecov Report

Merging #16437 (529079c) into master (6a2cec5) will increase coverage by 0.10%.
The diff coverage is 84.61%.

❗ Current head 529079c differs from pull request most recent head 39a9f2c. Consider uploading reports for the commit 39a9f2c to get more accurate results

@@            Coverage Diff             @@
##           master   #16437      +/-   ##
==========================================
+ Coverage   76.39%   76.50%   +0.10%     
==========================================
  Files        1001     1002       +1     
  Lines       53535    53637     +102     
  Branches     6822     6853      +31     
==========================================
+ Hits        40900    41033     +133     
+ Misses      12396    12365      -31     
  Partials      239      239              

Flag	Coverage Δ
javascript	70.81% <74.57%> (+<0.01%)	⬆️
mysql	81.56% <91.35%> (+0.02%)	⬆️
postgres	81.59% <91.66%> (+0.06%)	⬆️
presto	81.40% <91.66%> (?)
python	81.84% <91.66%> (+0.19%)	⬆️
sqlite	81.19% <91.35%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...set-frontend/src/components/ModalTrigger/index.jsx	95.65% <ø> (ø)
.../components/ExploreAdditionalActionsMenu/index.jsx	100.00% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx	2.11% <ø> (ø)
...et-frontend/src/explore/reducers/exploreReducer.js	32.00% <0.00%> (-0.44%)	⬇️
...t-frontend/src/explore/reducers/getInitialState.ts	30.00% <ø> (ø)
superset/models/slice.py	86.41% <ø> (ø)
...src/explore/components/controls/ViewQueryModal.tsx	76.92% <66.66%> (+0.92%)	⬆️
superset-frontend/src/components/Modal/Modal.tsx	85.22% <73.46%> (-14.78%)	⬇️
superset/utils/sqllab_execution_context.py	90.14% <90.14%> (ø)
...d/src/explore/components/PropertiesModal/index.tsx	81.94% <100.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2cec5...39a9f2c. Read the comment docs.

[stephenLYZ]

Frontend looks good to me! Thanks for the fixing. Is there any other state that can be maintained on the frontend only?

[zhaoyongjie]

LGTM

[villebro]

/testenv up

[github-actions]

@villebro Ephemeral environment spinning up at http://54.201.70.223:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[villebro]

@stephenLYZ :

Frontend looks good to me! Thanks for the fixing. Is there any other state that can be maintained on the frontend only?

Good question; I did briefly look into moving a few other properties to the frontend, but the other obvious candidates in this template (can_add and can_download) seemed like they were actually better handled in the backend. But I will definitely be on the lookout for similar simplifications in subsequent PRs.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.