refactor(monorepo): relocate superset-ui by zhaoyongjie · Pull Request #17445 · apache/superset

zhaoyongjie · 2021-11-16T08:25:34Z

SUMMARY

This PR MUST wait for monorepo-stage-2 to pass CI.
This PR MUST merged before monorepo-stage-2 .

add lerna.json in superset-frontend
add workspace in packages.json
run command npx lerna import --flatten --dest temporary_superset_ui ../../superset-ui to import all commits into superset-frontend. commit cut to : apache-superset/superset-ui@3e16995
discard workspace changing in packages.json (in order not to add new dependencies, dependencies will be added in stage-2 PR)
ignore temporary_superset_ui in pre-commit-config
remove *.ipynb from .gitignore
in order to support merge or squash this PR so temporarily update .asf.yml

To ensure that every PR passes the CI, the monorepo-related PR is split into multiple stages.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

ktmud

Thanks for working on this! This is the really large undertaking.

Just a reminder that when merging this PR, DON'T choose "Squash and merge", otherwise you'll lose all the git history.

ktmud · 2021-11-17T00:21:13Z

Before merging this PR, we must update .asf.yml to enable "Create merge commit", otherwise it is not possible:

codecov · 2021-11-24T02:26:43Z

Codecov Report

Merging #17445 (3832bd5) into master (a304116) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 3832bd5 differs from pull request most recent head 61a9517. Consider uploading reports for the commit 61a9517 to get more accurate results

@@            Coverage Diff             @@
##           master   #17445      +/-   ##
==========================================
+ Coverage   76.81%   76.95%   +0.14%     
==========================================
  Files        1049     1049              
  Lines       56671    56671              
  Branches     7851     7851              
==========================================
+ Hits        43529    43611      +82     
+ Misses      12889    12807      -82     
  Partials      253      253

Flag	Coverage Δ
javascript	`71.12% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/datasets/api.py	`90.13% <0.00%> (-0.90%)`	⬇️
superset/constants.py	`100.00% <0.00%> (ø)`
superset/utils/core.py	`89.76% <0.00%> (+0.11%)`	⬆️
superset/connectors/sqla/models.py	`87.07% <0.00%> (+0.22%)`	⬆️
superset/db_engine_specs/base.py	`88.54% <0.00%> (+0.38%)`	⬆️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx	`74.21% <0.00%> (+0.62%)`	⬆️
superset/db_engine_specs/presto.py	`84.34% <0.00%> (+0.83%)`	⬆️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx	`66.29% <0.00%> (+1.12%)`	⬆️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	`71.14% <0.00%> (+1.34%)`	⬆️
superset/views/database/mixins.py	`82.75% <0.00%> (+1.72%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a304116...61a9517. Read the comment docs.

geido

LGTM!

…che#1196)

* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder

* change to prettier.config.js * printWidth to 80 * format * tweak

* feat: remove the default Y-axis truncate in bar chart * make all charts consistently * fix lint

* feat(core): add support for adhoc columns * simplify import * revert simplification due to codecov * fix filter column type * fix pivot v2 groupbys * remove redundant import * Add new type guards * move ColumnMeta type guards to chart-controls * add type guard tests * Fix typing and import errors * Fix saved expression type guard * Fix typing * Remove redundant import * Make Echarts and PivotTable handle AdhocColumns properly * Fix lint Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

)

Co-authored-by: John Bodley <john.bodley@airbnb.com>

* chore: coordinate storybook with main repository * update lock file

…e#1465)

* chore: end of file fixer * compress image * lint without build * lintrc improvment * exporting * update parallel-coordinates tsconfig * add license to md file * add license * add eslintignore

…pache#1470)

villebro

LGTM, but let's not merge until non-squash merge is enabled

kgabryje

LGTM

nanzhinan · 2022-02-14T07:29:23Z

This is really a huge change, it's too friendly for developers, what version will be launched?

villebro · 2022-02-14T07:32:47Z

We are just about to make a new release cut for 1.5. Finalizing the first release candidate + shipping it usually takes some time, but you should be able to start testing the new release branch within the next few weeks

…perset_ui refactor(monorepo): relocate superset-ui

pull-request-size Bot added the size/XXL label Nov 16, 2021

zhaoyongjie changed the title ~~Monorepo relocate superset UI~~ refactor(monorepo): relocate superset UI Nov 16, 2021

zhaoyongjie changed the title ~~refactor(monorepo): relocate superset UI~~ refactor(monorepo): relocate superset-ui Nov 16, 2021

This was referenced Nov 16, 2021

refactor(monorepo): stage 1 #17427

Merged

refactor(monorepo): move superset-ui to superset(stage 2) #17437

Closed

junlincc requested review from amitmiran137, kristw, ktmud and mistercrunch November 16, 2021 23:58

ktmud approved these changes Nov 17, 2021

View reviewed changes

ktmud reviewed Nov 17, 2021

View reviewed changes

zhaoyongjie force-pushed the monorepo_relocate_superset_ui branch 4 times, most recently from 5149a63 to 7beb48a Compare November 17, 2021 09:34

rusackas added hold! On hold hold:testing! On hold for testing risk:many-files Change has too many files labels Nov 19, 2021

zhaoyongjie force-pushed the monorepo_relocate_superset_ui branch from 77baf62 to 511acb1 Compare November 21, 2021 02:34

rusackas added the risk:superset-ui label Nov 22, 2021

zhaoyongjie force-pushed the monorepo_relocate_superset_ui branch from 511acb1 to c597a7f Compare November 24, 2021 01:48

geido approved these changes Nov 24, 2021

View reviewed changes

zhaoyongjie mentioned this pull request Nov 25, 2021

refactor(monorepo): move superset-ui to superset(stage 2) #17552

Merged

zhaoyongjie force-pushed the monorepo_relocate_superset_ui branch from c597a7f to 1073f56 Compare November 25, 2021 03:08

suddjian and others added 4 commits November 26, 2021 11:47

chore: publish v0.17.60

4f1b768

add malaysia map. created via jupyter. (apache#1193)

0949825

fix(legacy-preset-chart-big-number): example images got mixed up (apa…

c160a4a

…che#1196)

fix(plugin-chart-echarts): sanitize series from html tags (apache#1126)

895d9d3

* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder

zhaoyongjie and others added 16 commits November 26, 2021 11:47

chore: refine prettier config as the main repository (apache#1456)

c78551d

* change to prettier.config.js * printWidth to 80 * format * tweak

feat: remove the default Y-axis truncate in bar chart (apache#1450)

4359ed0

* feat: remove the default Y-axis truncate in bar chart * make all charts consistently * fix lint

chore: publish v0.18.21

490029a

chore: coordinate superset-ui unittest with main repository (apache#1463

067fc8a

)

fix(plugin-chart-echarts): fix opacity on area chart (apache#1464)

e186adb

fix: update chart sorting control labels/descriptions (apache#1462)

3894cb0

Co-authored-by: John Bodley <john.bodley@airbnb.com>

chore: publish v0.18.22

b25e0d6

chore: coordinate storybook with main repository (apache#1466)

852478b

* chore: coordinate storybook with main repository * update lock file

fix(plugin-chart-pivot-table): cross filtering by adhoc column (apach…

2b8e4a1

…e#1465)

chore: publish v0.18.23

85e7d02

Pass dashboardId to control (apache#1467)

22d976a

chore: publish v0.18.24

0e60be4

chore: fix end-of-file (apache#1468)

d490ee8

* chore: end of file fixer * compress image * lint without build * lintrc improvment * exporting * update parallel-coordinates tsconfig * add license to md file * add license * add eslintignore

fix(plugin-chart-echarts): fix legend margin in radar and ts chart (a…

7f44a04

…pache#1470)

chore: publish v0.18.25

2836c80

zhaoyongjie force-pushed the monorepo_relocate_superset_ui branch from 1073f56 to 0b54635 Compare November 26, 2021 03:49

villebro approved these changes Nov 26, 2021

View reviewed changes

kgabryje reviewed Nov 26, 2021

View reviewed changes

Comment thread .asf.yaml Outdated

zhaoyongjie added 4 commits November 26, 2021 17:17

chore: ignore temporary_superset_ui checking

e7cc08a

chore: add .prettierignore and update pre-commit-config

fe1d910

chore: update gitignore

b1af254

chore: ignore temporary_superset_ui in jest config

61a9517

villebro mentioned this pull request Nov 26, 2021

chore: temporarily enable merge in .asf.yml #17560

Merged

9 tasks

zhaoyongjie force-pushed the monorepo_relocate_superset_ui branch from 0b54635 to 61a9517 Compare November 26, 2021 09:22

kgabryje approved these changes Nov 26, 2021

View reviewed changes

zhaoyongjie merged commit 870d2ab into apache:master Nov 26, 2021

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

Merge pull request apache#17445 from zhaoyongjie/monorepo_relocate_su…

adfa08d

…perset_ui refactor(monorepo): relocate superset-ui

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(monorepo): relocate superset-ui#17445

refactor(monorepo): relocate superset-ui#17445
zhaoyongjie merged 1866 commits into
apache:masterfrom
zhaoyongjie:monorepo_relocate_superset_ui

zhaoyongjie commented Nov 16, 2021 •

edited

Loading

Uh oh!

ktmud left a comment •

edited

Loading

Uh oh!

ktmud commented Nov 17, 2021 •

edited

Loading

Uh oh!

codecov Bot commented Nov 24, 2021 •

edited

Loading

Uh oh!

geido left a comment

Uh oh!

villebro left a comment

Uh oh!

Uh oh!

kgabryje left a comment

Uh oh!

nanzhinan commented Feb 14, 2022

Uh oh!

villebro commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

zhaoyongjie commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

ktmud left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ktmud commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geido left a comment

Choose a reason for hiding this comment

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kgabryje left a comment

Choose a reason for hiding this comment

Uh oh!

nanzhinan commented Feb 14, 2022

Uh oh!

villebro commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

zhaoyongjie commented Nov 16, 2021 •

edited

Loading

ktmud left a comment •

edited

Loading

ktmud commented Nov 17, 2021 •

edited

Loading

codecov Bot commented Nov 24, 2021 •

edited

Loading