feat: update time comparison choices (again)#17968
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17968 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
Jan 7, 2022
Member
etr2460
left a comment
There was a problem hiding this comment.
i'm happy to stamp, but let's see what @rusackas or @michael-s-molina think too before merge?
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Similar to #11294, this PR adds Y/3Y time comparison choices to make it faster to compare with pre-pandemic times.
We can make this change custom to our deployment, but thought it might be useful for all? We could remove these options later.
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION
@graceguo-supercat @etr2460