Skip to content

feat: update time comparison choices (again)#17968

Merged
etr2460 merged 1 commit into
apache:masterfrom
serenajiang:the-before-times
Jan 10, 2022
Merged

feat: update time comparison choices (again)#17968
etr2460 merged 1 commit into
apache:masterfrom
serenajiang:the-before-times

Conversation

@serenajiang
Copy link
Copy Markdown
Contributor

SUMMARY

Similar to #11294, this PR adds Y/3Y time comparison choices to make it faster to compare with pre-pandemic times.

We can make this change custom to our deployment, but thought it might be useful for all? We could remove these options later.

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@graceguo-supercat @etr2460

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2022

Codecov Report

Merging #17968 (6dcfa10) into master (c95d6bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17968   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64905    64905           
  Branches     6868     6868           
=======================================
  Hits        43537    43537           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
javascript 53.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 33.33% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <ø> (ø)
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 95.83% <ø> (ø)
...et-frontend/src/explore/controlPanels/sections.tsx 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95d6bf...6dcfa10. Read the comment docs.

Copy link
Copy Markdown
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm happy to stamp, but let's see what @rusackas or @michael-s-molina think too before merge?

Copy link
Copy Markdown
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etr2460 etr2460 merged commit 05d9cde into apache:master Jan 10, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 First shipped in 1.5.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0 First shipped in 1.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants