feat: update time comparison choices (again)#22458
Merged
john-bodley merged 1 commit intoDec 23, 2022
Merged
Conversation
ktmud
approved these changes
Dec 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #22458 +/- ##
=======================================
Coverage 66.89% 66.89%
=======================================
Files 1850 1850
Lines 70701 70701
Branches 7750 7750
=======================================
Hits 47292 47292
Misses 21393 21393
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
approved these changes
Dec 20, 2022
Member
Author
|
@villebro I'm aware of that (and did communicate it to our users), though it seems like they still likely the idea of having it explicitly defined. |
This was referenced Jan 3, 2023
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 24, 2023
(cherry picked from commit 9e81c3a)
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SUMMARY
Similar to #11294, this PR adds Y4Y time comparison choices to make it faster to compare with pre-pandemic times.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION