feat: update time comparison choices (again)#26173
Conversation
john-bodley
force-pushed
the
john-bodley--the-before-times
branch
from
5f9822b to
a6a7987
Compare
There was a problem hiding this comment.
It seems like the Y4Y comparison was removed in #22150, though it's not evident—per the PR description and/or comments—as to why, hence I re-added them.
john-bodley
force-pushed
the
john-bodley--the-before-times
branch
from
a6a7987 to
5c22c23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26173 +/- ##
=======================================
Coverage 69.21% 69.21%
=======================================
Files 1941 1943 +2
Lines 75910 75899 -11
Branches 8458 8451 -7
=======================================
- Hits 52541 52537 -4
- Misses 21174 21177 +3
+ Partials 2195 2185 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| ['2 years', t('2 years')], | ||
| ['156 weeks', t('156 weeks')], | ||
| ['3 years', t('3 years')], | ||
| ['208 weeks ago', t('208 weeks ago')], |
There was a problem hiding this comment.
@john-bodley Is there are reason to keep the time period in weeks when they match the year? Why not use weeks only when the number of weeks is not a multiple of 52?
There was a problem hiding this comment.
As Y4Y comparison was removed in #22150, the custom time shift option can vary in different scenarios. To ensure consistency, it is advisable to override the custom option by utilizing the chartControlRegistry on the vendor side.
There was a problem hiding this comment.
john-bodley Is there are reason to keep the time period in weeks when they match the year? Why not use weeks only when the number of weeks is not a multiple of 52?
In order to effectively analyze daily and weekly data and account for seasonal trends, it is essential to incorporate the weekly offset.
FYI:
Certain industries or businesses may experience specific patterns or trends on a weekly basis. For example, in the hospitality industry, weekends may have higher demand compared to weekdays. By using weeks as the time period, analysts can effectively capture these patterns and make more accurate predictions or recommendations.
There was a problem hiding this comment.
Thanks @justinpark for the additional context. @john-bodley I wonder if we should make these configurable somehow.
|
Closing in favor of implementing an internal custom override. It seems like Y4Y, Y5Y, etc. comparisons are very much organization dependent. |
3 participants
SUMMARY
Similar to #22458, this PR adds Y5Y time comparison choices to make it faster to compare with pre-pandemic times.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION