chore: Spelling by jsoref · Pull Request #19648 · apache/superset

jsoref · 2022-04-11T14:08:17Z

SUMMARY

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@d28d76e#commitcomment-70995512

The action reports that the changes in this PR would make it happy: jsoref@e50b893

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

I'm aware that this PR is quite large, it also includes a couple of API changes (which probably won't be acceptable). I'll try to tag items

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

jsoref

The majority of the corrections here were automatically suggested by Google Sheets.

A number of changes were done by me manually.

All file renames (or failures to rename files) are on me. I tried to at least rename all the files needed for CI (but clearly missed at least one image file).

I'm quite happy to split PRs like this into smaller bits (e.g. by directory or file type). I try very hard to avoid squashing until very late in the process as it makes rebasing very risky (I already rebased this once and hit one conflict).

I'll probably do one push to fix the items I've noted in this review.

I may also be a bit sporadically available for the next few weeks, but I should be able to respond w/in a week (even if I can't perform an update).

jsoref · 2022-04-11T14:09:53Z

 ```

-In terms of best practices please advoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled.
+In terms of best practices please avoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled.


Note: this PR is generally limited to spelling (including duplicate words). Grammatically, disabling would be better than disablement.

jsoref · 2022-04-11T14:10:14Z

 RUN apt-get update -y

-# Install dependencies to fix `curl https support error` and `elaying package configuration warning`
+# Install dependencies to fix `curl https support error` and `delaying package configuration warning`


When I saw this item flagged I guessed relaying, I was wrong.

jsoref · 2022-04-11T14:11:13Z

 try:
-    from github import BadCredentialsException, Github, PullRequest, Repository
+    from github import BadCredentialsException, GitHub, PullRequest, Repository
 except ModuleNotFoundError:
-    print("PyGithub is a required package for this script")
+    print("PyGitHub is a required package for this script")
    exit(1)


If these are third party modules, then these changes will break. It's trivial for me to drop individual change families although I'll probably try to carefully tease out the text and noncode instances of GitHub.

can you check that this change actually works by installing pygithub and trying to import that class?

Tested.

Apparently the project does at least occasionally call itself PyGitHub:
https://github.com/PyGithub/PyGithub/blob/001970d4a828017f704f6744a5775b4207a6523c/README.md?plain=1#L1

But, the classes/exceptions/methods aren't exposed via the proper spelling, so I'll have to fix up this commit (dropping most of the Python bits, but keeping the change for line 29).

As an aside, I can't get pip install -r ... to work, it dies on my m1 trying to do stuff using numpy (amd64 stuff at that!!):

numpy/core/src/multiarray/scalartypes.c.src:2967:65: error: too few arguments to function call, expected 2, have 1 return _Py_HashDouble((double) PyArrayScalar_VAL(obj, Float)); ~~~~~~~~~~~~~~ ^

I've tried a couple of versions of numpy and that didn't help.

jsoref · 2022-04-11T14:11:49Z

 - [13507](https://github.com/apache/superset/pull/13507) feat(native-filters): Filter set tabs (#13507) (@simcha90)
 - [14313](https://github.com/apache/superset/pull/14313) feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters (#14313) (@Kamil Gabryjelski)
- [14261](https://github.com/apache/superset/pull/14261) feat(native-filters): Show/Hide filter bar by metdata ff (#14261) (@simcha90)
+- [14261](https://github.com/apache/superset/pull/14261) feat(native-filters): Show/Hide filter bar by metadata ff (#14261) (@simcha90)


Some projects don't like changing release notes. Let me know if this is such a project, it's trivial for me to ignore files/paths.

jsoref · 2022-04-11T14:43:53Z

 class ColumnTypeSource(Enum):
    GET_TABLE = 1
-    CURSOR_DESCRIPION = 2
+    CURSOR_DESCRIPTION = 2


jsoref · 2022-04-11T14:46:25Z

    """
    Creates ANNOTATION_LAYERS_COUNT-1 layers with no annotations
-    and a final one with ANNOTATION_COUNT childs
+    and a final one with ANNOTATION_COUNT children


jsoref · 2022-04-11T14:46:58Z

                object_ref={"baz": "food"},
                log_to_statsd=False,
-                payload_override={"engine": "sqllite"},
+                payload_override={"engine": "sqlite"},


dpgaspar

Gave it a quick pass, maybe it would be better to split this PR in docs, python backend, frontend for example

jsoref · 2022-04-13T00:19:11Z

So, I've split these into pieces. Note that a couple conflict w/ each-other. I don't have the energy to deal w/ that now, but they're fairly trivial to deal w/ later.

Once each of the pieces are in, I'll rerun my tooling and see how things look and update this PR to pick up the pieces.

rusackas · 2023-02-17T23:11:34Z

@jsoref now that the other ones have merged (hooray and thank you!) do you want to rebase this one and keep going, or shall we close it?

codecov · 2023-02-19T08:46:14Z

Codecov Report

Merging #19648 (68257bf) into master (a823033) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 68257bf differs from pull request most recent head 40ebfa5. Consider uploading reports for the commit 40ebfa5 to get more accurate results

@@           Coverage Diff           @@
##           master   #19648   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        1918     1918           
  Lines       74151    74132   -19     
  Branches     8052     8043    -9     
=======================================
- Hits        50212    50201   -11     
+ Misses      21886    21881    -5     
+ Partials     2053     2050    -3

Flag	Coverage Δ
hive	`52.72% <77.77%> (ø)`
mysql	`78.53% <100.00%> (ø)`
postgres	`78.60% <100.00%> (ø)`
presto	`52.65% <77.77%> (ø)`
python	`82.44% <100.00%> (ø)`
sqlite	`77.11% <100.00%> (ø)`
unit	`52.62% <44.44%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/superset-ui-core/src/query/buildQueryObject.ts	`100.00% <ø> (ø)`
...packages/superset-ui-core/src/query/types/Query.ts	`100.00% <ø> (ø)`
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts	`100.00% <ø> (ø)`
...ins/legacy-plugin-chart-partition/src/Partition.js	`0.00% <ø> (ø)`
...gin-chart-echarts/src/Timeseries/transformProps.ts	`58.33% <ø> (ø)`
...tend/plugins/plugin-chart-table/src/TableChart.tsx	`44.91% <ø> (ø)`
...erset-frontend/src/SqlLab/components/App/index.jsx	`82.60% <ø> (-0.73%)`	⬇️
...d/src/SqlLab/components/QueryAutoRefresh/index.tsx	`58.62% <ø> (ø)`
...c/components/DeprecatedSelect/DeprecatedSelect.tsx	`41.33% <ø> (ø)`
...rontend/src/components/MetadataBar/MetadataBar.tsx	`98.18% <ø> (-0.04%)`	⬇️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jsoref

This is a naive conceptual rebase -- I made check-spelling reasonably happy, but didn't review the changes before pushing here.

jsoref · 2023-02-19T08:47:15Z

Comment to note a renamed file below

rusackas · 2023-04-06T21:38:47Z

I think the bulk of these changes were handled in your more granular PRs (thanks again for those). Should we rebase this one, or scrap it?

Clearly, we should follow up when time allows and add your tooling to our CI pipeline! SOOO MANY TYPOS!

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

rusackas · 2023-04-07T17:24:54Z

@dpgaspar @villebro I'm not sure if there's any risk in renaming a migration file like this. Do you know?

rusackas · 2023-04-07T17:26:09Z

Again, nervous about renaming these migrations... not sure if there's a real risk.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

rusackas · 2023-04-07T22:43:01Z

/testenv up

github-actions · 2023-04-07T22:44:56Z

@rusackas Ephemeral environment spinning up at http://54.191.2.216:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jsoref requested review from a team, craig-rueda, dpgaspar, geido, michael-s-molina and villebro as code owners April 11, 2022 14:08

pull-request-size Bot added the size/XL label Apr 11, 2022

jsoref commented Apr 11, 2022

View reviewed changes

jsoref force-pushed the spelling branch from 2a46339 to a1b9558 Compare April 12, 2022 01:38

pull-request-size Bot added size/XXL and removed size/XL labels Apr 12, 2022

dpgaspar reviewed Apr 12, 2022

View reviewed changes

Comment thread superset/views/base_api.py

Comment thread superset/viz.py Outdated

This was referenced Apr 13, 2022

chore(docs): Spelling #19675

Merged

chore(frontend): Spelling #19676

Merged

chore(backend): Spelling #19677

Merged

chore(misc): Spelling #19678

Merged

jsoref force-pushed the spelling branch from a1b9558 to 642ba5e Compare February 19, 2023 08:38

jsoref requested review from betodealmeida, eschutho, jinghua-qa and rusackas as code owners February 19, 2023 08:38

pull-request-size Bot added size/XL and removed size/XXL labels Feb 19, 2023

jsoref commented Feb 19, 2023

View reviewed changes

jsoref added 2 commits April 7, 2023 00:12

spelling: accepts

f57b541

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: advanced

680111c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 4 commits April 7, 2023 13:18

spelling: specific

630c622

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: specified

5336679

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: stopped

12e315c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: storybook

15109b8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from d054f9c to 0156b04 Compare April 7, 2023 17:19

rusackas reviewed Apr 7, 2023

View reviewed changes

jsoref added 16 commits April 7, 2023 13:32

spelling: successfully

854f0af

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: superset

c24bed4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: time

3a760e5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: to

f9286a9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: tooltip

017d1af

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transform

d4968ea

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: translation

7df4140

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: twitch

4568a15

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: types of

c4a7c37

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unknown

8becac2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: using

d37c7c5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: value

f9593c5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: variables

6882e61

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: when

407ac4b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whether

606b50f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore(helm): bump chart version

40ebfa5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from 0156b04 to 40ebfa5 Compare April 7, 2023 17:32

jsoref commented Apr 7, 2023

View reviewed changes

Comment thread superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts

jsoref commented Apr 7, 2023

View reviewed changes

Comment thread superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx

michael-s-molina closed this Sep 13, 2023

This was referenced Sep 28, 2023

chore(docs): Spelling #25453

Merged

chore(backend): Spelling #25457

Merged

Conversation

jsoref commented Apr 11, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpgaspar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jsoref commented Apr 13, 2022

Uh oh!

rusackas commented Feb 17, 2023

Uh oh!

codecov Bot commented Feb 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rusackas commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rusackas commented Apr 7, 2023

Uh oh!

github-actions Bot commented Apr 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Feb 19, 2023 •

edited

Loading