chore(docs): Spelling by jsoref · Pull Request #19675 · apache/superset

jsoref · 2022-04-13T00:01:21Z

SUMMARY

Subset of #19648 per #19648 (review)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

codecov · 2022-04-13T00:07:29Z

Codecov Report

Merging #19675 (9dbdd00) into master (b45f89b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19675      +/-   ##
==========================================
+ Coverage   66.49%   66.50%   +0.01%     
==========================================
  Files        1681     1683       +2     
  Lines       64370    64520     +150     
  Branches     6583     6607      +24     
==========================================
+ Hits        42803    42910     +107     
- Misses      19886    19916      +30     
- Partials     1681     1694      +13

Flag	Coverage Δ
hive	`52.69% <ø> (+0.02%)`	⬆️
javascript	`51.12% <ø> (-0.05%)`	⬇️
mysql	`81.95% <ø> (+0.05%)`	⬆️
postgres	`81.99% <ø> (+0.05%)`	⬆️
presto	`52.54% <ø> (+0.02%)`	⬆️
python	`82.43% <ø> (+0.05%)`	⬆️
sqlite	`81.77% <ø> (+0.05%)`	⬆️
unit	`47.75% <ø> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...src/components/FilterableTable/FilterableTable.tsx	`71.42% <ø> (ø)`
superset/charts/post_processing.py	`67.17% <ø> (ø)`
superset/utils/pandas_postprocessing/pivot.py	`91.17% <ø> (ø)`
...ins/plugin-chart-echarts/src/Pie/transformProps.ts	`55.07% <0.00%> (-12.93%)`	⬇️
superset-frontend/src/views/components/Menu.tsx	`50.00% <0.00%> (-10.00%)`	⬇️
...rontend/src/components/ListView/Filters/Search.tsx	`70.58% <0.00%> (-7.99%)`	⬇️
...rset-frontend/src/components/ListView/ListView.tsx	`94.11% <0.00%> (-4.64%)`	⬇️
...erset-frontend/src/components/EmptyState/index.tsx	`71.42% <0.00%> (-2.94%)`	⬇️
...frontend/src/components/ListView/Filters/index.tsx	`66.66% <0.00%> (-2.57%)`	⬇️
superset-frontend/src/views/CRUD/utils.tsx	`64.51% <0.00%> (-1.62%)`	⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45f89b...9dbdd00. Read the comment docs.

michael-s-molina

LGTM. This is awesome! Thank you so much @jsoref

* spelling: adding Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: aggregate Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: avoid Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: blacklist Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: cached Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: discontinue Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: exhaustive Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: from Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: github Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: hybrid Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: implicit Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: interim Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: introduced Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: javascript Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: logstash Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: metadata Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: password Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: recommended Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: redshift Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: refactored Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: referencing Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: sqlite Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: the Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: thumbnails Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: undoes Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: very Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 26 commits April 12, 2022 19:52

spelling: adding

3541e30

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: aggregate

ffab6a0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: avoid

d445c17

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: blacklist

2f65927

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: cached

3d89b2a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: discontinue

f251b43

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: exhaustive

2def6d2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: from

f1b8d69

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: github

2ca0076

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: hybrid

eaec6b2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: implicit

a464620

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: interim

c9fe9b3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: introduced

7fdf778

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: javascript

6a1f097

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: logstash

985e545

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: metadata

4b6cb31

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: password

a895449

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: recommended

7dfd668

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: redshift

b1bbdd8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: refactored

8c9c726

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: referencing

57f722e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: sqlite

2e93515

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: the

9be6cee

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: thumbnails

8e67eb7

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: undoes

95a5128

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: very

9dbdd00

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref requested a review from a team as a code owner April 13, 2022 00:01

pull-request-size Bot added the size/M label Apr 13, 2022

michael-s-molina approved these changes Apr 13, 2022

View reviewed changes

michael-s-molina merged commit c32c505 into apache:master Apr 26, 2022

jsoref deleted the spelling-docs branch April 26, 2022 16:31

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 First shipped in 2.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(docs): Spelling#19675

chore(docs): Spelling#19675
michael-s-molina merged 26 commits into
apache:masterfrom
jsoref:spelling-docs

jsoref commented Apr 13, 2022

Uh oh!

codecov Bot commented Apr 13, 2022 •

edited

Loading

Uh oh!

michael-s-molina left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jsoref commented Apr 13, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codecov Bot commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michael-s-molina left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 13, 2022 •

edited

Loading