fix(explore): Fix datasource switch for table chart

[codyml]

SUMMARY

Another casualty of #21315 was datasource switching for table chart: after that PR, switching between datasources wouldn't preserve any columns. As a side-effect, saving charts based on SQL queries instead of datasets would fail, as the save process involves switching from the query datasource to the newly-created dataset. This PR fixes the issue, which was specifically caused by #21315 turning chartState.options from an object into an array (see #21484).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

• Create a Table chart from a dataset in Raw mode and try switching datasets. Ensure that columns that exist on both datasets are preserved.
• Create a Table chart in Raw mode from a query and try saving it. Ensure that all control values remain unchanged after save.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21544 (f754013) into master (c66205f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #21544   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files        1793     1793           
  Lines       68538    68537    -1     
  Branches     7282     7282           
=======================================
  Hits        45702    45702           
+ Misses      20974    20973    -1     
  Partials     1862     1862           

Flag	Coverage Δ
javascript	52.86% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...lUtils/getControlValuesCompatibleWithDatasource.ts	8.00% <0.00%> (+0.30%)	⬆️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx	52.87% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lyndsiWilliams]

/testenv up

[github-actions]

@lyndsiWilliams Ephemeral environment spinning up at http://54.201.68.238:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

I found an issue that, when create chart with a result have time column, it seems like the time column will become number in explore, and user can not create time-series related charts
master:

in this pr:

[mayurnewase]

fixes: #21531

[codyml]

I found an issue that, when create chart with a result have time column, it seems like the time column will become number in explore, and user can not create time-series related charts
master:

in this pr:

@jinghua-qa Looking into this now, thanks!

[jinghua-qa]

I am able to reproduce in master for this issue, i try another dataset "Video Game Sales', when use chart-power-query, year open as # in explore and if open the dataset directly, year is a time column in the dataset. So i think this issue is not related to this PR and i will file issue seperately

[jinghua-qa]

However when i deployed pr changes to the preset workspace and test, i saw error msg for chart save ( but the chart is actually saved)

[stephenLYZ]

Thanks for the fix. It would be nice if we can add some tests.

[jinghua-qa]

Have tested in a workspace with recent superset master and it is working fine, the issue for the time column because string is not related to this PR. LGTM

[codyml]

Thanks for the fix. It would be nice if we can add some tests.

@stephenLYZ Thanks for the review! I have adding tests for this case on my list, am going to tackle it separately.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.