chore(explore): Add tests for getControlValuesCompatibleWithDatasource#21744
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21744 +/- ##
==========================================
+ Coverage 66.83% 66.86% +0.02%
==========================================
Files 1800 1800
Lines 68937 68943 +6
Branches 7335 7335
==========================================
+ Hits 46077 46100 +23
+ Misses 20967 20946 -21
- Partials 1893 1897 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
PR #21544 was a fix for something I broke in #21315. This PR adds unit tests for the
getControlValuesCompatibleWithDatasourcemodule, used when the datasource is switched in Explore to keep valid control values, that would have caught this bug.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION