Skip to content

feat: Updates button styles of Modal pre-defined functions#22737

Merged
michael-s-molina merged 1 commit into
apache:masterfrom
michael-s-molina:styles-modal-buttons
Jan 16, 2023
Merged

feat: Updates button styles of Modal pre-defined functions#22737
michael-s-molina merged 1 commit into
apache:masterfrom
michael-s-molina:styles-modal-buttons

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina commented Jan 15, 2023

SUMMARY

Updates button styles of Modal pre-defined functions to match our theme.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-01-15.at.10.55.34.AM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title feat: Updatess button styles of Modal pre-defined functions feat: Updates button styles of Modal pre-defined functions Jan 15, 2023
@michael-s-molina michael-s-molina mentioned this pull request Jan 15, 2023
Merged
9 tasks
geido
geido approved these changes Jan 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit d2a355b into apache:master Jan 16, 2023
@michael-s-molina michael-s-molina mentioned this pull request Jan 18, 2023
Closed
9 tasks
@rusackas rusackas mentioned this pull request Feb 2, 2023
Closed
@mistercrunch mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@michael-s-molina
feat: Updates button styles of Modal pre-defined functions (apache#22737
d625971 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geido geido geido approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michael-s-molina @geido @mistercrunch