feat: Generic X-axis improvements

[michael-s-molina]

SUMMARY

• Asks for confirmation when deleting the last temporal filter
• When changing a temporal X-axis and the value is not on the filters list, presents an option to add it
• Adds an information message to Time Range native filter explaining the relationship with temporal columns
• Enables the save button when adding a new Time Range with No Filter value

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-01-15.at.1.31.13.PM.mov

TESTING INSTRUCTIONS

• Check that a modal requiring confirmation is presented when deleting the last temporal filter
• Check that Time Range native filters present a message describing it relationship with temporal columns

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22707 (7033fed) into master (577ac81) will decrease coverage by 0.03%.
The diff coverage is 38.18%.

@@            Coverage Diff             @@
##           master   #22707      +/-   ##
==========================================
- Coverage   67.29%   67.27%   -0.03%     
==========================================
  Files        1877     1877              
  Lines       71939    71989      +50     
  Branches     7877     7891      +14     
==========================================
+ Hits        48412    48429      +17     
- Misses      21499    21531      +32     
- Partials     2028     2029       +1     

Flag	Coverage Δ
javascript	53.83% <38.18%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...Filters/FiltersConfigModal/FilterConfigurePane.tsx	100.00% <ø> (ø)
.../FilterControl/AdhocFilterPopoverTrigger/index.tsx	83.33% <ø> (ø)
...plore/components/controls/OptionControls/index.tsx	75.53% <0.00%> (-1.65%)	⬇️
...ontrols/FilterControl/AdhocFilterControl/index.jsx	46.60% <18.18%> (-3.40%)	⬇️
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx	41.60% <33.33%> (-1.01%)	⬇️
.../src/explore/components/ControlPanelsContainer.tsx	70.00% <42.30%> (-5.35%)	⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	59.93% <100.00%> (+0.42%)	⬆️
...ols/FilterControl/AdhocFilterEditPopover/index.jsx	70.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

I'll handle the dialog buttons theming in a separate PR as it's related to the Modal component.

[villebro]

Found a bug while testing: It seems the filter modal comment does not show up when adding the time range, but only after saving the filters and opening the filter bar modal again. Also, changing the filter type to something else doesn't remove it (same issue I assume). See video below. In addition, a few stylistic/wording improvement ideas.

pr-22707.mp4

[michael-s-molina]

Found a bug while testing: It seems the filter modal comment does not show up when adding the time range, but only after saving the filters and opening the filter bar modal again. Also, changing the filter type to something else doesn't remove it (same issue I assume).

Fixed.

[villebro]

LGTM and tested to work as expected with an optional component naming idea.

[sadpandajoe]

🏷️ preset:2023.3